Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5

Issue 2838513002: DO NOT LAND. Revert of https://codereview.chromium.org/2797963002 (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 // This file specifies fields in ComputedStyle that we would like to 2 // This file specifies fields in ComputedStyle that we would like to
3 // generate, but are not CSS properties. 3 // generate, but are not CSS properties.
4 4
5 parameters: { 5 parameters: {
6 // - field_size 6 // - field_size
7 // Number of bits needed to store this field. Only used for storage_only 7 // Number of bits needed to store this field. Only used for storage_only
8 // fields. If specified, the field will be stored as bit field. Otherwise 8 // fields. If specified, the field will be stored as bit field. Otherwise
9 // it will be stored as a normal data member. 9 // it will be stored as a normal data member.
10 field_size: { 10 field_size: {
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 default_value: "false", 95 default_value: "false",
96 has_custom_compare_and_copy: true, 96 has_custom_compare_and_copy: true,
97 }, 97 },
98 // Explicitly inherits a non-inherited property 98 // Explicitly inherits a non-inherited property
99 { 99 {
100 name: "HasExplicitlyInheritedProperties", 100 name: "HasExplicitlyInheritedProperties",
101 field_template: "monotonic_flag", 101 field_template: "monotonic_flag",
102 default_value: "false", 102 default_value: "false",
103 has_custom_compare_and_copy: true, 103 has_custom_compare_and_copy: true,
104 }, 104 },
105 // These are set if we used viewport or rem units when resolving a length.
106 // TODO(shend): HasViewportUnits should be a monotonic_flag.
107 {
108 name: "HasViewportUnits",
109 field_template: "primitive",
110 default_value: "false",
111 type_name: "bool",
112 has_custom_compare_and_copy: true,
113 },
114 {
115 name: "HasRemUnits",
116 field_template: "monotonic_flag",
117 default_value: "false",
118 has_custom_compare_and_copy: true,
119 },
120 // These properties only have generated storage, and their methods are handw ritten in ComputedStyle. 105 // These properties only have generated storage, and their methods are handw ritten in ComputedStyle.
121 // TODO(shend): Remove these fields and delete the 'storage_only' template. 106 // TODO(shend): Remove these fields and delete the 'storage_only' template.
122 { 107 {
123 name: "EmptyState", 108 name: "EmptyState",
124 field_template: "storage_only", 109 field_template: "storage_only",
125 field_size: 1, 110 field_size: 1,
126 default_value: "false", 111 default_value: "false",
127 type_name: "bool", 112 type_name: "bool",
128 has_custom_compare_and_copy: true, 113 has_custom_compare_and_copy: true,
129 }, 114 },
(...skipping 29 matching lines...) Expand all
159 { 144 {
160 name: "VerticalAlign", 145 name: "VerticalAlign",
161 field_template: "storage_only", 146 field_template: "storage_only",
162 field_size: 4, 147 field_size: 4,
163 default_value: "EVerticalAlign::kBaseline", 148 default_value: "EVerticalAlign::kBaseline",
164 type_name: "EVerticalAlign", 149 type_name: "EVerticalAlign",
165 has_custom_compare_and_copy: true, 150 has_custom_compare_and_copy: true,
166 }, 151 },
167 ], 152 ],
168 } 153 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698