[Payments] Cache payment manifests.

components/payments/android/payment_manifest_web_data_service.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_PAYMENTS_ANDROID_PAYMENT_MANIFEST_WEB_DATA_SERVICE_H_
+

[please use gerrit instead, 2017/04/24 18:22:32]

#define COMPONENTS_PAYMENTS_ANDROID_PAYMENT_MANIFEST_WEB_DATA_SERVICE_H_

[gogerald1, 2017/04/26 13:46:33]

Done.

+#include "base/memory/ref_counted.h"
+#include "components/payments/android/payment_method_manifest_table.h"
+#include "components/payments/android/web_app_manifest_section_table.h"
+#include "components/webdata/common/web_data_results.h"
+#include "components/webdata/common/web_data_service_base.h"
+#include "components/webdata/common/web_data_service_consumer.h"
+#include "components/webdata/common/web_database_service.h"
+
+namespace payments {
+
+// Web data service to read/write data in WebAppManifestSectionTable and
+// PaymentMethodManifestTable.
+class PaymentManifestWebDataService : public WebDataServiceBase {
+ public:
+  PaymentManifestWebDataService(
+      scoped_refptr<WebDatabaseService> wdbs,
+      const ProfileErrorCallback& callback,
+      const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread);
+
+  // Adds the web app |manifest|.
+  void AddPaymentWebAppManifest(
+      const std::vector<mojom::WebAppManifestSectionPtr>& manifest);
+
+  // Gets the |web_app|'s manifest.
+  WebDataServiceBase::Handle GetPaymentWebAppManifest(
+      const std::string& web_app,
+      WebDataServiceConsumer* consumer);
+
+  // Adds the |payment_method|'s manifest.
+  void AddPaymentMethodManifest(const std::string& payment_method,
+                                const std::vector<std::string>& web_app_ids);

[please use gerrit instead, 2017/04/24 18:22:32]

s/web_app_id/android_app_package_name/g (or simply "package_name")

Here and everywhere.

[gogerald1, 2017/04/26 13:46:33]

Done.

+
+  // Gets the |payment_method|'s manifest.
+  WebDataServiceBase::Handle GetPaymentMethodManifest(
+      const std::string& payment_method,
+      WebDataServiceConsumer* consumer);
+
+ protected:
+  ~PaymentManifestWebDataService() override;

[please use gerrit instead, 2017/04/24 18:22:32]

Why is this protected?

[gogerald1, 2017/04/26 13:46:33]

Not allowed to be destructed from outside of this class. Moved it to private.
This class object is destructed by calling Destroy().

[please use gerrit instead, 2017/04/26 15:00:43]

I don't see Destroy() anywhere in payment_manifest_web_data_service.h. Can you
point me to it?

[gogerald1, 2017/04/26 17:30:30]

Ah, sorry, I thought this is payment_manifest_web_data_service_android.

Actually, this class is instantiated when constructing WebDataServiceWrapper
which is a keyed service. And it is not expected to be destructed. Note that the
destructor of the base class WebDataServiceBase is declared protected.

+
+ private:
+  WebDatabase::State AddPaymentWebAppManifestImpl(
+      const std::vector<mojom::WebAppManifestSectionPtr>& manifest,
+      WebDatabase* db);
+  WebDatabase::State AddPaymentMethodManifestImpl(
+      const std::string& payment_method,
+      const std::vector<std::string>& web_app_ids,
+      WebDatabase* db);
+
+  std::unique_ptr<WDTypedResult> GetPaymentWebAppManifestImpl(
+      const std::string& web_app,
+      WebDatabase* db);
+  std::unique_ptr<WDTypedResult> GetPaymentMethodManifestImpl(
+      const std::string& payment_method,
+      WebDatabase* db);
+
+  DISALLOW_COPY_AND_ASSIGN(PaymentManifestWebDataService);
+};
+
+}  // namespace payments
+
+#endif  // COMPONENTS_PAYMENTS_ANDROID_PAYMENT_MANIFEST_WEB_DATA_SERVICE_H_