android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java - Issue 2838383002: Move Minidump Uploading IO operations off the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

Issue 2838383002: Move Minidump Uploading IO operations off the UI thread. (Closed)

Patch Set: Don't fail test if uploadFinished called - we don't guarantee ng. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

diff --git a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

index 2e373c6a32989c73ae871dfab0404f72c8764f2c..ff7b8d530c205a046491272a32041616a5b81130 100644

--- a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

+++ b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

@@ -37,7 +37,7 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate {

@Override

public File getCrashParentDir() {

- return CrashReceiverService.getOrCreateWebViewCrashDir();

+ return CrashReceiverService.getWebViewCrashDir();

}

@Override

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java » ('j') | no next file with comments »