ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.h - Issue 2838373002: Adding Sign-in promo for bookmark view.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.h

Issue 2838373002: Adding Sign-in promo for bookmark view. (Closed)

Patch Set: Remove consumer and comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm ('K') | « ios/chrome/browser/ui/bookmarks/bookmark_folder_collection_view.mm ('k') | ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm » ('j') | ios/chrome/browser/ui/bookmarks/bookmark_signin_promo_cell.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_SIGNIN_PROMO_CELL_H_

	6 #define IOS_CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_SIGNIN_PROMO_CELL_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 @class SigninPromoView;

	11

	12 // Sign-in promo cell based on SigninPromoView. This cell invite the user to
	msarda 2017/04/27 11:58:24 s/invite/invites s/invite/invites jlebel 2017/04/27 14:01:28 Done. Show quoted text On 2017/04/27 11:58:24, msarda wrote: > s/invite/invites Done.
	13 // login without typing their password (based on "CONTINUE AS").
	msarda 2017/04/27 11:58:24 Remove "(based on "CONTINUE AS")" (I do not unders Remove "(based on "CONTINUE AS")" (I do not understand what that means). jlebel 2017/04/27 14:01:28 Done. Show quoted text On 2017/04/27 11:58:24, msarda wrote: > Remove "(based on "CONTINUE AS")" (I do not understand what that means). Done.
	14 @interface BookmarkSigninPromoCell : UICollectionViewCell

	15

	16 // Identifier for -[UICollectionView registerClass:forCellWithReuseIdentifier:].

	17 + (NSString*)reuseIdentifier;

	18

	19 // SigninPromoView view.
	msarda 2017/04/27 11:58:24 This comment is useless (it is the same as the nam This comment is useless (it is the same as the name of the property). Remove it. jlebel 2017/04/27 14:01:28 Done. Show quoted text On 2017/04/27 11:58:24, msarda wrote: > This comment is useless (it is the same as the name of the property). Remove it. Done. lpromero 2017/04/27 15:49:11 Maybe: The sign-in promo view embedded in this cel Show quoted text On 2017/04/27 14:01:28, jlebel wrote: > On 2017/04/27 11:58:24, msarda wrote: > > This comment is useless (it is the same as the name of the property). Remove > it. > > Done. Maybe: The sign-in promo view embedded in this cell.
	20 @property(nonatomic, readonly) SigninPromoView* signinPromoView;

	21

	22 @end

	23

	24 #endif // IOS_CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_SIGNIN_PROMO_CELL_H_

OLD	NEW