chrome/browser/resources/settings/internet_page/network_summary_item.js - Issue 2838323002: [CrOS Tether] Add tether settings section to the MD settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/network_summary_item.js

Issue 2838323002: [CrOS Tether] Add tether settings section to the MD settings page. (Closed)

Patch Set: Fix Closure compiler error. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_summary.js ('k') | chrome/browser/resources/settings/settings_ui/settings_ui.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/network_summary_item.js

diff --git a/chrome/browser/resources/settings/internet_page/network_summary_item.js b/chrome/browser/resources/settings/internet_page/network_summary_item.js

index 55fb84b127fbdcf30e024fb5ea168594234bccca..b16ea0be1a3e4c6fd3c0ffb13a8a5363d5587116 100644

--- a/chrome/browser/resources/settings/internet_page/network_summary_item.js

+++ b/chrome/browser/resources/settings/internet_page/network_summary_item.js

@@ -188,6 +188,8 @@ Polymer({

if (!this.enableToggleIsVisible_(deviceState))

return '';

switch (deviceState.Type) {

+ case CrOnc.Type.TETHER:

+ return this.i18n('internetToggleTetherA11yLabel');

case CrOnc.Type.CELLULAR:

return this.i18n('internetToggleMobileA11yLabel');

case CrOnc.Type.WI_FI:

@@ -214,7 +216,8 @@ Polymer({

shouldShowList_: function() {

var minlen = (this.deviceState.Type == CrOnc.Type.WI_FI ||

- this.deviceState.Type == CrOnc.Type.VPN) ?

+ this.deviceState.Type == CrOnc.Type.VPN ||

+ this.deviceState.Type == CrOnc.Type.TETHER) ?

1 :

return this.networkStateList.length >= minlen;