Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4345)

Unified Diff: chrome/browser/resources/settings/internet_page/network_summary.js

Issue 2838323002: [CrOS Tether] Add tether settings section to the MD settings page. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/network_summary.js
diff --git a/chrome/browser/resources/settings/internet_page/network_summary.js b/chrome/browser/resources/settings/internet_page/network_summary.js
index 35b0c2913d0f97e5a596a00ea0ac8035001d8e19..ea377084f278d5da9be764a8ba1d574dda5a4285 100644
--- a/chrome/browser/resources/settings/internet_page/network_summary.js
+++ b/chrome/browser/resources/settings/internet_page/network_summary.js
@@ -286,6 +286,7 @@ Polymer({
// Complete list of states by type.
/** @type {!NetworkStateListObject} */ var newNetworkStateLists = {
Ethernet: [],
+ Tether: [],
WiFi: [],
Cellular: [],
WiMAX: [],
@@ -302,9 +303,7 @@ Polymer({
firstConnectedNetwork = networkState;
}
}
- if (newNetworkStateLists.hasOwnProperty(type)) {
- newNetworkStateLists[type].push(networkState);
- }
+ newNetworkStateLists[type].push(networkState);
}, this);
this.defaultNetwork = firstConnectedNetwork;
@@ -322,8 +321,8 @@ Polymer({
var newActiveNetworkStates = [];
this.activeNetworkIds_ = new Set;
var orderedDeviceTypes = [
- CrOnc.Type.ETHERNET, CrOnc.Type.WI_FI, CrOnc.Type.CELLULAR,
- CrOnc.Type.WI_MAX, CrOnc.Type.VPN
+ CrOnc.Type.ETHERNET, CrOnc.Type.TETHER, CrOnc.Type.WI_FI,
stevenjb 2017/04/26 17:05:08 Let's place TETHER after CELLULAR for now.
Kyle Horimoto 2017/04/26 17:17:41 Done.
+ CrOnc.Type.CELLULAR, CrOnc.Type.WI_MAX, CrOnc.Type.VPN
];
for (var i = 0; i < orderedDeviceTypes.length; ++i) {
var type = orderedDeviceTypes[i];

Powered by Google App Engine
This is Rietveld 408576698