chrome/browser/resources/settings/internet_page/internet_detail_page.js - Issue 2838323002: [CrOS Tether] Add tether settings section to the MD settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2838323002: [CrOS Tether] Add tether settings section to the MD settings page. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/network_ui/network_ui.js ('k') | chrome/browser/resources/settings/internet_page/internet_subpage.js » ('j') | chrome/browser/resources/settings/internet_page/network_property_list.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

index 760db46b12bb8dc04ce4cc261f140da8efee0e0e..3ae4476a29cb0cbe0571bb9dc1a5c861cf78b6e9 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

@@ -129,6 +129,7 @@ Polymer({

value: {

CELLULAR: CrOnc.Type.CELLULAR,

ETHERNET: CrOnc.Type.ETHERNET,

+ TETHER: CrOnc.Type.TETHER,

VPN: CrOnc.Type.VPN,

WIFI: CrOnc.Type.WI_FI,

WIMAX: CrOnc.Type.WI_MAX,

@@ -774,6 +775,10 @@ Polymer({

fields.push(

'Cellular.ActivationState', 'Cellular.RoamingState',

'RestrictedConnectivity', 'Cellular.ServingOperator.Name');

+ } else if (type == CrOnc.Type.TETHER && !!this.networkProperties.Tether) {

+ fields.push(

+ 'Tether.BatteryPercentage', 'Tether.SignalStrength',

+ 'Tether.Carrier');

} else if (type == CrOnc.Type.VPN && !!this.networkProperties.VPN) {

var vpnType = CrOnc.getActiveValue(this.networkProperties.VPN.Type);

if (vpnType == 'ThirdPartyVPN') {