Issue 28383003: Handle misaligned loads and stores in load elimination. Do not track misaligned loads and be conser…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28383003: Handle misaligned loads and stores in load elimination. Do not track misaligned loads and be conser… (Closed)

Created:
7 years, 2 months ago by titzer

Modified:
7 years, 2 months ago

Reviewers:
Benedikt Meurer, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handle misaligned loads and stores in load elimination. Do not track misaligned loads and be conservative about invalidating misaligned stores. Add more tests for number conversion to string (NumberToStringStub exhibits misaligned loads) BUG=v8:2934 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17294

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+492 lines, -7 lines)			Patch
M	src/hydrogen-load-elimination.cc	View	4 chunks	+36 lines, -7 lines	0 comments	Download
A	test/mjsunit/number-tostring-add.js	View	1 chunk	+89 lines, -0 lines	0 comments	Download
A	test/mjsunit/number-tostring-func.js	View	1 chunk	+367 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

titzer

7 years, 2 months ago (2013-10-21 13:33:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17294 (presubmit successful).

Expand Messages | Collapse Messages