Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: webrtc/api/peerconnectioninterface.h

Issue 2838233002: Add PeerConnectionInterface::UpdateCallBitrate with call tests. (Closed)
Patch Set: Only update start from SetBitrateConfig when it changes; some comments and logging. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | webrtc/call/call.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 const std::vector<cricket::Candidate>& candidates) { 724 const std::vector<cricket::Candidate>& candidates) {
725 return false; 725 return false;
726 } 726 }
727 727
728 // Register a metric observer (used by chromium). 728 // Register a metric observer (used by chromium).
729 // 729 //
730 // There can only be one observer at a time. Before the observer is 730 // There can only be one observer at a time. Before the observer is
731 // destroyed, RegisterUMAOberver(nullptr) should be called. 731 // destroyed, RegisterUMAOberver(nullptr) should be called.
732 virtual void RegisterUMAObserver(UMAObserver* observer) = 0; 732 virtual void RegisterUMAObserver(UMAObserver* observer) = 0;
733 733
734 // 0 <= min <= current <= max should hold for set parameters.
735 struct BitrateParameters {
736 rtc::Optional<int> min_bitrate_bps;
737 rtc::Optional<int> current_bitrate_bps;
738 rtc::Optional<int> max_bitrate_bps;
739 };
740
741 // SetBitrate limits the bandwidth allocated for all RTP streams sent by
742 // this PeerConnection. Other limitations might affect these limits and
743 // are respected (for example "b=AS" in SDP).
744 //
745 // Changing |current_bitrate_bps| to a new value will reset the current
746 // bitrate estimate to the provided value.
747 virtual RTCError SetBitrate(const BitrateParameters& bitrate) = 0;
748
734 // Returns the current SignalingState. 749 // Returns the current SignalingState.
735 virtual SignalingState signaling_state() = 0; 750 virtual SignalingState signaling_state() = 0;
736 virtual IceConnectionState ice_connection_state() = 0; 751 virtual IceConnectionState ice_connection_state() = 0;
737 virtual IceGatheringState ice_gathering_state() = 0; 752 virtual IceGatheringState ice_gathering_state() = 0;
738 753
739 // Starts RtcEventLog using existing file. Takes ownership of |file| and 754 // Starts RtcEventLog using existing file. Takes ownership of |file| and
740 // passes it on to Call, which will take the ownership. If the 755 // passes it on to Call, which will take the ownership. If the
741 // operation fails the file will be closed. The logging will stop 756 // operation fails the file will be closed. The logging will stop
742 // automatically after 10 minutes have passed, or when the StopRtcEventLog 757 // automatically after 10 minutes have passed, or when the StopRtcEventLog
743 // function is called. 758 // function is called.
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
1107 cricket::WebRtcVideoEncoderFactory* encoder_factory, 1122 cricket::WebRtcVideoEncoderFactory* encoder_factory,
1108 cricket::WebRtcVideoDecoderFactory* decoder_factory) { 1123 cricket::WebRtcVideoDecoderFactory* decoder_factory) {
1109 return CreatePeerConnectionFactory( 1124 return CreatePeerConnectionFactory(
1110 worker_and_network_thread, worker_and_network_thread, signaling_thread, 1125 worker_and_network_thread, worker_and_network_thread, signaling_thread,
1111 default_adm, encoder_factory, decoder_factory); 1126 default_adm, encoder_factory, decoder_factory);
1112 } 1127 }
1113 1128
1114 } // namespace webrtc 1129 } // namespace webrtc
1115 1130
1116 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ 1131 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | webrtc/call/call.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698