Split the ScopedSubresourceFilterFeatureToggle into two helper classes.

components/subresource_filter/core/browser/subresource_filter_features_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/subresource_filter/core/browser/subresource_filter_features.h"
 
 #include <string>
 
 #include "base/metrics/field_trial.h"
+#include "base/metrics/field_trial_params.h"
 #include "components/subresource_filter/core/browser/subresource_filter_features_test_support.h"
+#include "components/variations/variations_associated_data.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace subresource_filter {
+namespace testing {
+
+namespace {
+
+constexpr const char kTestFieldTrialName[] = "FieldTrialNameShouldNotMatter";
+constexpr const char kTestExperimentGroupName[] = "GroupNameShouldNotMatter";
+
+class ScopedExperimentalStateToggle {
+ public:
+  ScopedExperimentalStateToggle(
+      base::FeatureList::OverrideState feature_state,

[Charlie Harrison, 2017/04/25 19:36:22]

#include feature_list

[engedy, 2017/04/25 20:13:24]

Done.

+      std::map<std::string, std::string> variation_params)

[Charlie Harrison, 2017/04/25 19:36:22]

#include <map>

[engedy, 2017/04/25 20:13:24]

Done.

+      : field_trial_list_(nullptr /* entropy_provider */),
+        scoped_configurator_(nullptr) {
+    EXPECT_TRUE(base::AssociateFieldTrialParams(
+        kTestFieldTrialName, kTestExperimentGroupName, variation_params));
+    base::FieldTrial* field_trial = base::FieldTrialList::CreateFieldTrial(
+        kTestFieldTrialName, kTestExperimentGroupName);
+
+    std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);

[Charlie Harrison, 2017/04/25 19:36:21]

#include <memory>

[Charlie Harrison, 2017/04/25 19:36:21]

can you use base::MakeUnique?

[engedy, 2017/04/25 20:13:25]

Done.

[engedy, 2017/04/25 20:13:25]

Done.

+    feature_list->RegisterFieldTrialOverride(
+        kSafeBrowsingSubresourceFilter.name, feature_state, field_trial);
+    scoped_feature_list_.InitWithFeatureList(std::move(feature_list));
+  }
+
+  ~ScopedExperimentalStateToggle() {
+    variations::testing::ClearAllVariationParams();
+  }
+
+ private:
+  base::FieldTrialList field_trial_list_;
+
+  ScopedSubresourceFilterConfigurator scoped_configurator_;
+  base::test::ScopedFeatureList scoped_feature_list_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedExperimentalStateToggle);

[Charlie Harrison, 2017/04/25 19:36:22]

#include base/macros

[engedy, 2017/04/25 20:13:25]

Done.

+};
+
+}  // namespace
+}  // namespace testing
 
 TEST(SubresourceFilterFeaturesTest, ActivationLevel) {
   const struct {
     bool feature_enabled;
     const char* activation_level_param;
     ActivationLevel expected_activation_level;
   } kTestCases[] = {{false, "", ActivationLevel::DISABLED},
                     {false, "disabled", ActivationLevel::DISABLED},
                     {false, "dryrun", ActivationLevel::DISABLED},
                     {false, "enabled", ActivationLevel::DISABLED},
                     {false, "%$ garbage !%", ActivationLevel::DISABLED},
                     {true, "", ActivationLevel::DISABLED},
                     {true, "disable", ActivationLevel::DISABLED},
                     {true, "Disable", ActivationLevel::DISABLED},
                     {true, "disabled", ActivationLevel::DISABLED},
                     {true, "%$ garbage !%", ActivationLevel::DISABLED},
                     {true, kActivationLevelDryRun, ActivationLevel::DRYRUN},
                     {true, kActivationLevelEnabled, ActivationLevel::ENABLED},
                     {true, "Enabled", ActivationLevel::ENABLED}};
 
   for (const auto& test_case : kTestCases) {
     SCOPED_TRACE(::testing::Message("Enabled = ") << test_case.feature_enabled);
     SCOPED_TRACE(::testing::Message("ActivationLevelParam = \"")
                  << test_case.activation_level_param << "\"");
 
-    base::FieldTrialList field_trial_list(nullptr /* entropy_provider */);
-    testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
+    testing::ScopedExperimentalStateToggle scoped_experimental_state(
         test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
                                   : base::FeatureList::OVERRIDE_USE_DEFAULT,
-        test_case.activation_level_param, kActivationScopeNoSites);
+        {{kActivationLevelParameterName, test_case.activation_level_param},
+         {kActivationScopeParameterName, kActivationScopeNoSites}});
 
     const auto active_configurations = GetActiveConfigurations();
     const Configuration& actual_configuration =
         active_configurations->the_one_and_only();
     EXPECT_EQ(test_case.expected_activation_level,
               actual_configuration.activation_level);
     EXPECT_EQ(ActivationScope::NO_SITES, actual_configuration.activation_scope);
   }
 }
 
@@ skipping 14 matching lines @@
       {true, "no_sites", ActivationScope::NO_SITES},
       {true, "%$ garbage !%", ActivationScope::NO_SITES},
       {true, kActivationScopeAllSites, ActivationScope::ALL_SITES},
       {true, kActivationScopeActivationList, ActivationScope::ACTIVATION_LIST}};
 
   for (const auto& test_case : kTestCases) {
     SCOPED_TRACE(::testing::Message("Enabled = ") << test_case.feature_enabled);
     SCOPED_TRACE(::testing::Message("ActivationScopeParam = \"")
                  << test_case.activation_scope_param << "\"");
 
-    base::FieldTrialList field_trial_list(nullptr /* entropy_provider */);
-    testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
+    testing::ScopedExperimentalStateToggle scoped_experimental_state(
         test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
                                   : base::FeatureList::OVERRIDE_USE_DEFAULT,
-        kActivationLevelDisabled, test_case.activation_scope_param);
+        {{kActivationLevelParameterName, kActivationLevelDisabled},
+         {kActivationScopeParameterName, test_case.activation_scope_param}});
 
     const auto active_configurations = GetActiveConfigurations();
     const Configuration& actual_configuration =
         active_configurations->the_one_and_only();
     EXPECT_EQ(ActivationLevel::DISABLED, actual_configuration.activation_level);
     EXPECT_EQ(test_case.expected_activation_scope,
               actual_configuration.activation_scope);
   }
 }
 
@@ skipping 28 matching lines @@
       {true, kActivationLevelEnabled, ActivationLevel::ENABLED,
        kActivationScopeAllSites, ActivationScope::ALL_SITES},
       {true, kActivationLevelEnabled, ActivationLevel::ENABLED,
        kActivationScopeActivationList, ActivationScope::ACTIVATION_LIST},
       {true, kActivationLevelEnabled, ActivationLevel::ENABLED,
        kActivationScopeAllSites, ActivationScope::ALL_SITES},
       {false, kActivationLevelEnabled, ActivationLevel::DISABLED,
        kActivationScopeAllSites, ActivationScope::NO_SITES}};
 
   for (const auto& test_case : kTestCases) {
-    base::FieldTrialList field_trial_list(nullptr /* entropy_provider */);
-    testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
+    testing::ScopedExperimentalStateToggle scoped_experimental_state(
         test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
                                   : base::FeatureList::OVERRIDE_USE_DEFAULT,
-        test_case.activation_level_param, test_case.activation_scope_param);
+        {{kActivationLevelParameterName, test_case.activation_level_param},
+         {kActivationScopeParameterName, test_case.activation_scope_param}});
 
     const auto active_configurations = GetActiveConfigurations();
     const Configuration& actual_configuration =
         active_configurations->the_one_and_only();
     EXPECT_EQ(test_case.expected_activation_level,
               actual_configuration.activation_level);
     EXPECT_EQ(test_case.expected_activation_scope,
               actual_configuration.activation_scope);
   }
 }
@@ skipping 32 matching lines @@
        ActivationList::PHISHING_INTERSTITIAL},
       {true, socEngCommaPhisingCommaGarbage.c_str(),
        ActivationList::PHISHING_INTERSTITIAL},
       {true, "List1, List2", ActivationList::NONE}};
 
   for (const auto& test_case : kTestCases) {
     SCOPED_TRACE(::testing::Message("Enabled = ") << test_case.feature_enabled);
     SCOPED_TRACE(::testing::Message("ActivationListParam = \"")
                  << test_case.activation_list_param << "\"");
 
-    base::FieldTrialList field_trial_list(nullptr /* entropy_provider */);
-    testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
+    testing::ScopedExperimentalStateToggle scoped_experimental_state(
         test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
                                   : base::FeatureList::OVERRIDE_USE_DEFAULT,
-        kActivationLevelDisabled, kActivationScopeNoSites,
-        test_case.activation_list_param);
+        {{kActivationLevelParameterName, kActivationLevelDisabled},
+         {kActivationScopeParameterName, kActivationScopeNoSites},
+         {kActivationListsParameterName, test_case.activation_list_param}});
 
     const auto active_configurations = GetActiveConfigurations();
     const Configuration& actual_configuration =
         active_configurations->the_one_and_only();
     EXPECT_EQ(test_case.expected_activation_list,
               actual_configuration.activation_list);
   }
 }
 
 TEST(SubresourceFilterFeaturesTest, PerfMeasurementRate) {
@@ skipping 13 matching lines @@
                     {true, "1", 1},
                     {true, "1.0", 1},
                     {true, "0.333", 0.333},
                     {true, "1e0", 1}};
 
   for (const auto& test_case : kTestCases) {
     SCOPED_TRACE(::testing::Message("Enabled = ") << test_case.feature_enabled);
     SCOPED_TRACE(::testing::Message("PerfMeasurementParam = \"")
                  << test_case.perf_measurement_param << "\"");
 
-    base::FieldTrialList field_trial_list(nullptr /* entropy_provider */);
-    testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
+    testing::ScopedExperimentalStateToggle scoped_experimental_state(
         test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
                                   : base::FeatureList::OVERRIDE_USE_DEFAULT,
         {{kPerformanceMeasurementRateParameterName,
           test_case.perf_measurement_param}});
 
     const auto active_configurations = GetActiveConfigurations();
     const Configuration& actual_configuration =
         active_configurations->the_one_and_only();
     EXPECT_EQ(test_case.expected_perf_measurement_rate,
               actual_configuration.performance_measurement_rate);
@@ skipping 14 matching lines @@
                     {true, "invalid value", false},
                     {true, "True", true},
                     {true, "TRUE", true},
                     {true, "true", true}};
 
   for (const auto& test_case : kTestCases) {
     SCOPED_TRACE(::testing::Message("Enabled = ") << test_case.feature_enabled);
     SCOPED_TRACE(::testing::Message("SuppressNotificationsParam = \"")
                  << test_case.suppress_notifications_param << "\"");
 
-    base::FieldTrialList field_trial_list(nullptr /* entropy_provider */);
-    testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
+    testing::ScopedExperimentalStateToggle scoped_experimental_state(
         test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
                                   : base::FeatureList::OVERRIDE_USE_DEFAULT,
         {{kSuppressNotificationsParameterName,
           test_case.suppress_notifications_param}});
 
     const auto active_configurations = GetActiveConfigurations();
     const Configuration& actual_configuration =
         active_configurations->the_one_and_only();
     EXPECT_EQ(test_case.expected_suppress_notifications_value,
               actual_configuration.should_suppress_notifications);
@@ skipping 14 matching lines @@
                     {true, "invalid value", false},
                     {true, "True", true},
                     {true, "TRUE", true},
                     {true, "true", true}};
 
   for (const auto& test_case : kTestCases) {
     SCOPED_TRACE(::testing::Message("Enabled = ") << test_case.feature_enabled);
     SCOPED_TRACE(::testing::Message("WhitelistSiteOnReloadParam = \"")
                  << test_case.whitelist_site_on_reload_param << "\"");
 
-    base::FieldTrialList field_trial_list(nullptr /* entropy_provider */);
-    testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
+    testing::ScopedExperimentalStateToggle scoped_experimental_state(
         test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
                                   : base::FeatureList::OVERRIDE_USE_DEFAULT,
         {{kWhitelistSiteOnReloadParameterName,
           test_case.whitelist_site_on_reload_param}});
 
     const auto active_configurations = GetActiveConfigurations();
     const Configuration& actual_configuration =
         active_configurations->the_one_and_only();
     EXPECT_EQ(test_case.expected_whitelist_site_on_reload_value,
               actual_configuration.should_whitelist_site_on_reload);
   }
 }
 
+TEST(SubresourceFilterFeaturesTest, RulesetFlavor) {
+  const struct {
+    bool feature_enabled;
+    const char* ruleset_flavor_param;
+    const char* expected_ruleset_flavor_value;
+  } kTestCases[] = {
+      {false, "", ""}, {false, "a", ""}, {false, "test value", ""},
+      {true, "", ""},  {true, "a", "a"}, {true, "test value", "test value"}};
+
+  for (const auto& test_case : kTestCases) {
+    SCOPED_TRACE(::testing::Message("Enabled = ") << test_case.feature_enabled);
+    SCOPED_TRACE(::testing::Message("Flavor = \"")
+                 << test_case.ruleset_flavor_param << "\"");
+
+    testing::ScopedExperimentalStateToggle scoped_experimental_state(
+        test_case.feature_enabled ? base::FeatureList::OVERRIDE_ENABLE_FEATURE
+                                  : base::FeatureList::OVERRIDE_USE_DEFAULT,
+        {{kRulesetFlavorParameterName, test_case.ruleset_flavor_param}});
+
+    const auto active_configurations = GetActiveConfigurations();
+    const Configuration& actual_configuration =
+        active_configurations->the_one_and_only();
+    EXPECT_EQ(std::string(test_case.expected_ruleset_flavor_value),
+              actual_configuration.ruleset_flavor);
+  }
+}
 }  // namespace subresource_filter