Split the ScopedSubresourceFilterFeatureToggle into two helper classes.

components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h"
 
 #include <set>
 #include <string>
 
 #include "base/macros.h"
@@ skipping 71 matching lines @@
     case ActivationList::SUBRESOURCE_FILTER:
       return "SubresourceFilterOnly";
     case ActivationList::NONE:
       return std::string();
   }
   return std::string();
 }
 
 struct ActivationListTestData {
   ActivationDecision expected_activation_decision;
-  const char* const activation_list;
+  ActivationList activation_list;
   safe_browsing::SBThreatType threat_type;
   safe_browsing::ThreatPatternType threat_type_metadata;
 };
 
 const ActivationListTestData kActivationListTestData[] = {
-    {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED, "",
+    {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED, ActivationList::NONE,
      safe_browsing::SB_THREAT_TYPE_URL_PHISHING,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListSocialEngineeringAdsInterstitial,
+     ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_URL_PHISHING,
      safe_browsing::ThreatPatternType::NONE},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListSocialEngineeringAdsInterstitial,
+     ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_URL_PHISHING,
      safe_browsing::ThreatPatternType::MALWARE_LANDING},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListSocialEngineeringAdsInterstitial,
+     ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_URL_PHISHING,
      safe_browsing::ThreatPatternType::MALWARE_DISTRIBUTION},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListPhishingInterstitial,
+     ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_API_ABUSE,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListPhishingInterstitial,
+     ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_BLACKLISTED_RESOURCE,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListPhishingInterstitial,
+     ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListPhishingInterstitial,
+     ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_BINARY_MALWARE_URL,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListPhishingInterstitial,
+     ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_URL_UNWANTED,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListPhishingInterstitial,
+     ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_URL_MALWARE,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListPhishingInterstitial,
+     ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     subresource_filter::kActivationListPhishingInterstitial,
-     safe_browsing::SB_THREAT_TYPE_SAFE,
+     ActivationList::PHISHING_INTERSTITIAL, safe_browsing::SB_THREAT_TYPE_SAFE,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
-    {ActivationDecision::ACTIVATED,
-     subresource_filter::kActivationListPhishingInterstitial,
+    {ActivationDecision::ACTIVATED, ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_URL_PHISHING,
      safe_browsing::ThreatPatternType::NONE},
-    {ActivationDecision::ACTIVATED,
-     subresource_filter::kActivationListSocialEngineeringAdsInterstitial,
+    {ActivationDecision::ACTIVATED, ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_URL_PHISHING,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
-    {ActivationDecision::ACTIVATED,
-     subresource_filter::kActivationListPhishingInterstitial,
+    {ActivationDecision::ACTIVATED, ActivationList::PHISHING_INTERSTITIAL,
      safe_browsing::SB_THREAT_TYPE_URL_PHISHING,
      safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS},
 };
 
 struct ActivationScopeTestData {
   ActivationDecision expected_activation_decision;
   bool url_matches_activation_list;
-  const char* const activation_scope;
+  ActivationScope activation_scope;
 };
 
 const ActivationScopeTestData kActivationScopeTestData[] = {
     {ActivationDecision::ACTIVATED, false /* url_matches_activation_list */,
-     kActivationScopeAllSites},
+     ActivationScope::ALL_SITES},
     {ActivationDecision::ACTIVATED, true /* url_matches_activation_list */,
-     kActivationScopeAllSites},
+     ActivationScope::ALL_SITES},
     {ActivationDecision::ACTIVATION_DISABLED,
-     true /* url_matches_activation_list */, kActivationScopeNoSites},
+     true /* url_matches_activation_list */, ActivationScope::NO_SITES},
     {ActivationDecision::ACTIVATED, true /* url_matches_activation_list */,
-     kActivationScopeActivationList},
+     ActivationScope::ACTIVATION_LIST},
     {ActivationDecision::ACTIVATION_LIST_NOT_MATCHED,
-     false /* url_matches_activation_list */, kActivationScopeActivationList},
+     false /* url_matches_activation_list */, ActivationScope::ACTIVATION_LIST},
 };
 
 struct ActivationLevelTestData {
   ActivationDecision expected_activation_decision;
-  const char* const activation_level;
+  ActivationLevel activation_level;
 };
 
 const ActivationLevelTestData kActivationLevelTestData[] = {
-    {ActivationDecision::ACTIVATED, kActivationLevelDryRun},
-    {ActivationDecision::ACTIVATED, kActivationLevelEnabled},
-    {ActivationDecision::ACTIVATION_DISABLED, kActivationLevelDisabled},
+    {ActivationDecision::ACTIVATED, ActivationLevel::DRYRUN},
+    {ActivationDecision::ACTIVATED, ActivationLevel::ENABLED},
+    {ActivationDecision::ACTIVATION_DISABLED, ActivationLevel::DISABLED},
 };
 
 class MockSubresourceFilterClient : public SubresourceFilterClient {
  public:
   MockSubresourceFilterClient(VerifiedRulesetDealer::Handle* ruleset_dealer)
       : ruleset_dealer_(ruleset_dealer) {}
 
   ~MockSubresourceFilterClient() override = default;
 
   bool ShouldSuppressActivation(content::NavigationHandle* handle) override {
@@ skipping 39 matching lines @@
     rules.push_back(testing::CreateSuffixRule("disallowed.html"));
     ASSERT_NO_FATAL_FAILURE(test_ruleset_creator_.CreateRulesetWithRules(
         rules, &test_ruleset_pair_));
     ruleset_dealer_ = base::MakeUnique<VerifiedRulesetDealer::Handle>(
         base::MessageLoop::current()->task_runner());
     ruleset_dealer_->SetRulesetFile(
         testing::TestRuleset::Open(test_ruleset_pair_.indexed));
     client_ = new MockSubresourceFilterClient(ruleset_dealer_.get());
     ContentSubresourceFilterDriverFactory::CreateForWebContents(
         RenderViewHostTestHarness::web_contents(), base::WrapUnique(client()));
+    ResetConfigurationToEnableFilteringOnSocialEngineeringSites();
 
     // Add a subframe.
     content::RenderFrameHostTester* rfh_tester =
         content::RenderFrameHostTester::For(main_rfh());
     rfh_tester->InitializeRenderFrameIfNeeded();
     rfh_tester->AppendChild(kSubframeName);
 
     Observe(content::RenderViewHostTestHarness::web_contents());
   }
 
   void TearDown() override {
     ruleset_dealer_.reset();
     base::RunLoop().RunUntilIdle();
     RenderViewHostTestHarness::TearDown();
   }
 
+  void ResetConfiguration(Configuration config) {
+    scoped_configuration_.ResetConfiguration(std::move(config));
+  }
+
+  void ResetConfigurationToEnableFilteringOnAllSites() {
+    ResetConfiguration(
+        Configuration(ActivationLevel::ENABLED, ActivationScope::ALL_SITES));
+  }
+
+  void ResetConfigurationToEnableFilteringOnSocialEngineeringSites() {
+    ResetConfiguration(Configuration(
+        ActivationLevel::ENABLED, ActivationScope::ACTIVATION_LIST,
+        ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL));
+  }
+
   ContentSubresourceFilterDriverFactory* factory() {
     return ContentSubresourceFilterDriverFactory::FromWebContents(
         RenderViewHostTestHarness::web_contents());
   }
 
   MockSubresourceFilterClient* client() { return client_; }
 
   content::RenderFrameHost* GetSubframeRFH() {
     for (content::RenderFrameHost* rfh :
          RenderViewHostTestHarness::web_contents()->GetAllFrames()) {
@@ skipping 198 matching lines @@
  private:
   static bool expected_measure_performance() {
     const double rate = GetActiveConfigurations()
                             ->the_one_and_only()
                             .performance_measurement_rate;
     // Note: The case when 0 < rate < 1 is not deterministic, don't test it.
     EXPECT_TRUE(rate == 0 || rate == 1);
     return rate == 1;
   }
 
+  testing::ScopedSubresourceFilterConfigurator scoped_configuration_;
   testing::TestRulesetCreator test_ruleset_creator_;
   testing::TestRulesetPair test_ruleset_pair_;
 
   // Owned by the factory.
   MockSubresourceFilterClient* client_;
 
   std::unique_ptr<VerifiedRulesetDealer::Handle> ruleset_dealer_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSubresourceFilterDriverFactoryTest);
 };
@@ skipping 27 matching lines @@
  public:
   ContentSubresourceFilterDriverFactoryActivationLevelTest() {}
   ~ContentSubresourceFilterDriverFactoryActivationLevelTest() override {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(
       ContentSubresourceFilterDriverFactoryActivationLevelTest);
 };
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest,
-       ActivateForFrameHostDisabledFeature) {
-  // Activation scope is set to NONE => no activation should happen even if URL
-  // which is visited was a SB hit.
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_DISABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeAllSites,
-      kActivationListSocialEngineeringAdsInterstitial);
+       NoActivationWhenActivationLevelIsDisabled) {
+  Configuration config(ActivationLevel::DISABLED,
+                       ActivationScope::ACTIVATION_LIST,
+                       ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL);
+  config.activation_level = ActivationLevel::DISABLED;
+  ResetConfiguration(std::move(config));
+
   const GURL url(kExampleUrlWithParams);
   NavigateAndExpectActivation({true}, {url}, NO_REDIRECTS_HIT,
                               ActivationDecision::ACTIVATION_DISABLED);
   factory()->client()->WhitelistInCurrentWebContents(url);
   NavigateAndExpectActivation({true}, {url}, NO_REDIRECTS_HIT,
                               ActivationDecision::ACTIVATION_DISABLED);
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest, NoActivationWhenNoMatch) {
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeActivationList,
-      kActivationListSocialEngineeringAdsInterstitial);
   NavigateAndExpectActivation({false}, {GURL(kExampleUrl)}, EMPTY,
                               ActivationDecision::ACTIVATION_LIST_NOT_MATCHED);
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest,
        SpecialCaseNavigationAllSitesEnabled) {
   // Check that when the experiment is enabled for all site, the activation
   // signal is always sent.
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeAllSites);
+  ResetConfigurationToEnableFilteringOnAllSites();
   EmulateInPageNavigation({false}, EMPTY, ActivationDecision::ACTIVATED);
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest,
        SpecialCaseNavigationActivationListEnabled) {
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeActivationList,
-      kActivationListSocialEngineeringAdsInterstitial);
   EmulateInPageNavigation({true}, NO_REDIRECTS_HIT,
                           ActivationDecision::ACTIVATED);
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest,
        SpecialCaseNavigationActivationListEnabledWithPerformanceMeasurement) {
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeActivationList,
-      kActivationListSocialEngineeringAdsInterstitial,
-      "1" /* performance_measurement_rate */);
+  Configuration config(ActivationLevel::ENABLED,
+                       ActivationScope::ACTIVATION_LIST,
+                       ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL);
+  config.performance_measurement_rate = 1.0;
+  ResetConfiguration(std::move(config));
+
   EmulateInPageNavigation({true}, NO_REDIRECTS_HIT,
                           ActivationDecision::ACTIVATED);
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest, FailedNavigation) {
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeAllSites);
   const GURL url(kExampleUrl);
+  ResetConfigurationToEnableFilteringOnAllSites();
   NavigateAndExpectActivation({false}, {url}, EMPTY,
                               ActivationDecision::ACTIVATED);
   EmulateFailedNavigationAndExpectNoActivation(url);
 }
 
 // TODO(melandory): refactor the test so it no longer require the current
 // activation list to be matching.
 TEST_F(ContentSubresourceFilterDriverFactoryTest, RedirectPatternTest) {
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeActivationList,
-      kActivationListSocialEngineeringAdsInterstitial);
   struct RedirectRedirectChainMatchPatternTestData {
     std::vector<bool> blacklisted_urls;
     std::vector<GURL> navigation_chain;
     RedirectChainMatchPattern hit_expected_pattern;
     ActivationDecision expected_activation_decision;
   } kRedirectRedirectChainMatchPatternTestData[] = {
       {{false},
        {GURL(kUrlA)},
        EMPTY,
        ActivationDecision::ACTIVATION_LIST_NOT_MATCHED},
@@ skipping 69 matching lines @@
         test_data.blacklisted_urls, test_data.navigation_chain,
         safe_browsing::SB_THREAT_TYPE_SUBRESOURCE_FILTER,
         safe_browsing::ThreatPatternType::NONE, content::Referrer(),
         ui::PAGE_TRANSITION_LINK, test_data.hit_expected_pattern,
         ActivationDecision::ACTIVATION_LIST_NOT_MATCHED);
 #endif
   }
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest, NotificationVisibility) {
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeAllSites);
+  ResetConfigurationToEnableFilteringOnAllSites();
   NavigateAndExpectActivation({false}, {GURL(kExampleUrl)}, EMPTY,
                               ActivationDecision::ACTIVATED);
   EXPECT_CALL(*client(), ToggleNotificationVisibility(true)).Times(1);
   NavigateSubframeAndExpectCheckResult(GURL(kDisallowedUrl),
                                        true /* expect_cancelled */);
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest,
        SuppressNotificationVisibility) {
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeAllSites, "" /* activation_lists */,
-      "" /* performance_measurement_rate */,
-      "true" /* suppress_notifications */);
+  Configuration config(ActivationLevel::ENABLED, ActivationScope::ALL_SITES);
+  config.should_suppress_notifications = true;
+  ResetConfiguration(std::move(config));
   NavigateAndExpectActivation({false}, {GURL(kExampleUrl)}, EMPTY,
                               ActivationDecision::ACTIVATED);
   EXPECT_CALL(*client(), ToggleNotificationVisibility(::testing::_)).Times(0);
   NavigateSubframeAndExpectCheckResult(GURL(kDisallowedUrl),
                                        true /* expect_cancelled */);
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest,
        InactiveMainFrame_SubframeNotFiltered) {
   GURL url(kExampleUrl);
+  Configuration config(ActivationLevel::DISABLED, ActivationScope::ALL_SITES);
+  ResetConfiguration(std::move(config));
   NavigateAndExpectActivation({false}, {url}, EMPTY,
                               ActivationDecision::ACTIVATION_DISABLED);
   NavigateSubframeAndExpectCheckResult(url, false /* expect_cancelled */);
 }
 
 TEST_F(ContentSubresourceFilterDriverFactoryTest, WhitelistSiteOnReload) {
   const struct {
     content::Referrer referrer;
     ui::PageTransition transition;
     ActivationDecision expected_activation_decision;
   } kTestCases[] = {
       {content::Referrer(), ui::PAGE_TRANSITION_LINK,
        ActivationDecision::ACTIVATED},
       {content::Referrer(GURL(kUrlA), blink::kWebReferrerPolicyDefault),
        ui::PAGE_TRANSITION_LINK, ActivationDecision::ACTIVATED},
       {content::Referrer(GURL(kExampleUrl), blink::kWebReferrerPolicyDefault),
        ui::PAGE_TRANSITION_LINK, ActivationDecision::URL_WHITELISTED},
       {content::Referrer(), ui::PAGE_TRANSITION_RELOAD,
        ActivationDecision::URL_WHITELISTED}};
 
   for (const auto& test_case : kTestCases) {
     SCOPED_TRACE(::testing::Message("referrer = \"")
                  << test_case.referrer.url << "\""
                  << " transition = \"" << test_case.transition << "\"");
 
-    base::FieldTrialList field_trial_list(nullptr);
-    testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-        base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-        kActivationScopeAllSites, "" /* activation_lists */,
-        "" /* performance_measurement_rate */, "" /* suppress_notifications */,
-        "true" /* whitelist_site_on_reload */);
+    Configuration config(ActivationLevel::ENABLED, ActivationScope::ALL_SITES);
+    config.should_whitelist_site_on_reload = true;
+    ResetConfiguration(std::move(config));
 
     NavigateAndExpectActivation(
         {false}, {GURL(kExampleUrl)},
         safe_browsing::SB_THREAT_TYPE_URL_PHISHING,
         safe_browsing::ThreatPatternType::SOCIAL_ENGINEERING_ADS,
         test_case.referrer, test_case.transition, EMPTY,
         test_case.expected_activation_decision);
     // Verify that if the first URL failed to activate, subsequent same-origin
     // navigations also fail to activate.
     NavigateAndExpectActivation({false}, {GURL(kExampleUrlWithParams)}, EMPTY,
                                 test_case.expected_activation_decision);
   }
 }
 
 TEST_P(ContentSubresourceFilterDriverFactoryActivationLevelTest,
        ActivateForFrameState) {
   const ActivationLevelTestData& test_data = GetParam();
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, test_data.activation_level,
-      kActivationScopeActivationList,
-      kActivationListSocialEngineeringAdsInterstitial);
+  ResetConfiguration(Configuration(
+      test_data.activation_level, ActivationScope::ACTIVATION_LIST,
+      ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL));
 
   const GURL url(kExampleUrlWithParams);
   NavigateAndExpectActivation({true}, {url}, NO_REDIRECTS_HIT,
                               test_data.expected_activation_decision);
   factory()->client()->WhitelistInCurrentWebContents(url);
   NavigateAndExpectActivation(
       {true}, {GURL(kExampleUrlWithParams)}, NO_REDIRECTS_HIT,
       GetActiveConfigurations()->the_one_and_only().activation_level ==
               ActivationLevel::DISABLED
           ? ActivationDecision::ACTIVATION_DISABLED
           : ActivationDecision::URL_WHITELISTED);
 }
 
 TEST_P(ContentSubresourceFilterDriverFactoryThreatTypeTest,
        ActivateForTheListType) {
   // Sets up the experiment in a way that the activation decision depends on the
   // list for which the Safe Browsing hit has happened.
   const ActivationListTestData& test_data = GetParam();
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      kActivationScopeActivationList, test_data.activation_list);
+  ResetConfiguration(Configuration(ActivationLevel::ENABLED,
+                                   ActivationScope::ACTIVATION_LIST,
+                                   test_data.activation_list));
 
   const GURL test_url("https://example.com/nonsoceng?q=engsocnon");
   std::vector<GURL> navigation_chain;
 
   ActivationList effective_list = GetListForThreatTypeAndMetadata(
       test_data.threat_type, test_data.threat_type_metadata);
   NavigateAndExpectActivation(
       {false, false, false, true},
       {GURL(kUrlA), GURL(kUrlB), GURL(kUrlC), test_url}, test_data.threat_type,
       test_data.threat_type_metadata, content::Referrer(),
       ui::PAGE_TRANSITION_LINK,
       effective_list != ActivationList::NONE ? F0M0L1 : EMPTY,
       test_data.expected_activation_decision);
 };
 
 TEST_P(ContentSubresourceFilterDriverFactoryActivationScopeTest,
        ActivateForScopeType) {
   const ActivationScopeTestData& test_data = GetParam();
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      test_data.activation_scope,
-      kActivationListSocialEngineeringAdsInterstitial);
+  ResetConfiguration(
+      Configuration(ActivationLevel::ENABLED, test_data.activation_scope,
+                    ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL));
 
   const GURL test_url(kExampleUrlWithParams);
 
   RedirectChainMatchPattern expected_pattern =
       test_data.url_matches_activation_list ? NO_REDIRECTS_HIT : EMPTY;
   NavigateAndExpectActivation({test_data.url_matches_activation_list},
                               {test_url}, expected_pattern,
                               test_data.expected_activation_decision);
   if (test_data.url_matches_activation_list) {
     factory()->client()->WhitelistInCurrentWebContents(test_url);
     NavigateAndExpectActivation(
         {test_data.url_matches_activation_list}, {GURL(kExampleUrlWithParams)},
         expected_pattern,
         GetActiveConfigurations()->the_one_and_only().activation_scope ==
                 ActivationScope::NO_SITES
             ? ActivationDecision::ACTIVATION_DISABLED
             : ActivationDecision::URL_WHITELISTED);
   }
 };
 
 // Only main frames with http/https schemes should activate, unless the
 // activation scope is for all sites.
 TEST_P(ContentSubresourceFilterDriverFactoryActivationScopeTest,
        ActivateForSupportedUrlScheme) {
   const ActivationScopeTestData& test_data = GetParam();
-  base::FieldTrialList field_trial_list(nullptr);
-  testing::ScopedSubresourceFilterFeatureToggle scoped_feature_toggle(
-      base::FeatureList::OVERRIDE_ENABLE_FEATURE, kActivationLevelEnabled,
-      test_data.activation_scope,
-      kActivationListSocialEngineeringAdsInterstitial);
+  ResetConfiguration(
+      Configuration(ActivationLevel::ENABLED, test_data.activation_scope,
+                    ActivationList::SOCIAL_ENG_ADS_INTERSTITIAL));
 
   // data URLs are also not supported, but not listed here, as it's not possible
   // for a page to redirect to them after https://crbug.com/594215 is fixed.
   const char* unsupported_urls[] = {"ftp://example.com/", "chrome://settings",
                                     "chrome-extension://some-extension",
                                     "file:///var/www/index.html"};
   const char* supported_urls[] = {"http://example.test",
                                   "https://example.test"};
   for (auto* url : unsupported_urls) {
     SCOPED_TRACE(url);
@@ skipping 23 matching lines @@
     ActivationScopeTest,
     ContentSubresourceFilterDriverFactoryActivationScopeTest,
     ::testing::ValuesIn(kActivationScopeTestData));
 
 INSTANTIATE_TEST_CASE_P(
     ActivationLevelTest,
     ContentSubresourceFilterDriverFactoryActivationLevelTest,
     ::testing::ValuesIn(kActivationLevelTestData));
 
 }  // namespace subresource_filter