Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/builtins/builtins-console.cc

Issue 2838143002: [d8] console methods must not throw. (Closed)
Patch Set: fix for non-intl build Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/d8-console.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-console.cc
diff --git a/src/builtins/builtins-console.cc b/src/builtins/builtins-console.cc
index a021c8a75b2e4d90dfee99da7daf0a3bde4fc7dd..a43fe136d0a802c90950da915f33fc5be042ca78 100644
--- a/src/builtins/builtins-console.cc
+++ b/src/builtins/builtins-console.cc
@@ -45,6 +45,8 @@ namespace internal {
if (isolate->console_delegate()) { \
debug::ConsoleCallArguments wrapper(args); \
isolate->console_delegate()->name(wrapper); \
+ CHECK(!isolate->has_pending_exception()); \
kozy 2017/04/26 23:00:42 What is motivation behind this check? I just wonde
+ CHECK(!isolate->has_scheduled_exception()); \
} \
return isolate->heap()->undefined_value(); \
}
« no previous file with comments | « no previous file | src/d8-console.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698