Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/Source/core/dom/TreeScopeTest.cpp

Issue 2838123002: Count element name validity per DOM versus HTML parsing. (Closed)
Patch Set: Do not need the attribute counting. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp b/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
index 7bf29e45b1844c8ec7adfc4e25576d0ac02ce811..9b9c12062f8b7df44d8b93a69772632c064c9584 100644
--- a/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
+++ b/third_party/WebKit/Source/core/dom/TreeScopeTest.cpp
@@ -16,7 +16,8 @@ TEST(TreeScopeTest, CommonAncestorOfSameTrees) {
Document* document = Document::Create();
EXPECT_EQ(document, document->CommonAncestorTreeScope(*document));
- Element* html = document->createElement("html", StringOrDictionary());
+ Element* html =
+ document->createElement(nullptr, "html", StringOrDictionary());
document->AppendChild(html);
ShadowRoot* shadow_root =
html->CreateShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
@@ -29,7 +30,8 @@ TEST(TreeScopeTest, CommonAncestorOfInclusiveTrees) {
// shadowRoot
Document* document = Document::Create();
- Element* html = document->createElement("html", StringOrDictionary());
+ Element* html =
+ document->createElement(nullptr, "html", StringOrDictionary());
document->AppendChild(html);
ShadowRoot* shadow_root =
html->CreateShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
@@ -44,11 +46,14 @@ TEST(TreeScopeTest, CommonAncestorOfSiblingTrees) {
// A B
Document* document = Document::Create();
- Element* html = document->createElement("html", StringOrDictionary());
+ Element* html =
+ document->createElement(nullptr, "html", StringOrDictionary());
document->AppendChild(html);
- Element* head = document->createElement("head", StringOrDictionary());
+ Element* head =
+ document->createElement(nullptr, "head", StringOrDictionary());
html->AppendChild(head);
- Element* body = document->createElement("body", StringOrDictionary());
+ Element* body =
+ document->createElement(nullptr, "body", StringOrDictionary());
html->AppendChild(body);
ShadowRoot* shadow_root_a =
@@ -68,11 +73,14 @@ TEST(TreeScopeTest, CommonAncestorOfTreesAtDifferentDepths) {
// A
Document* document = Document::Create();
- Element* html = document->createElement("html", StringOrDictionary());
+ Element* html =
+ document->createElement(nullptr, "html", StringOrDictionary());
document->AppendChild(html);
- Element* head = document->createElement("head", StringOrDictionary());
+ Element* head =
+ document->createElement(nullptr, "head", StringOrDictionary());
html->AppendChild(head);
- Element* body = document->createElement("body", StringOrDictionary());
+ Element* body =
+ document->createElement(nullptr, "body", StringOrDictionary());
html->AppendChild(body);
ShadowRoot* shadow_root_y =
@@ -80,7 +88,8 @@ TEST(TreeScopeTest, CommonAncestorOfTreesAtDifferentDepths) {
ShadowRoot* shadow_root_b =
body->CreateShadowRootInternal(ShadowRootType::V0, ASSERT_NO_EXCEPTION);
- Element* div_in_y = document->createElement("div", StringOrDictionary());
+ Element* div_in_y =
+ document->createElement(nullptr, "div", StringOrDictionary());
shadow_root_y->AppendChild(div_in_y);
ShadowRoot* shadow_root_a = div_in_y->CreateShadowRootInternal(
ShadowRootType::V0, ASSERT_NO_EXCEPTION);
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.idl ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698