[shared_page_state] Fix unit test

telemetry/telemetry/page/shared_page_state_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import unittest
 
+from telemetry.core import platform as platform_module
 from telemetry.internal import story_runner
 from telemetry.page import page
 from telemetry.page import legacy_page_test
 from telemetry.page import shared_page_state
 from telemetry import story as story_module
 from telemetry.testing import fakes
 from telemetry.util import wpr_modes
 
 
 def SetUpPageRunnerArguments(options):
@@ skipping 58 matching lines @@
     story_set = story_module.StorySet()
     story_set.AddStory(story)
     story.shared_state_class(test, self.options, story_set)
     browser_options = self.options.browser_options
     actual_user_agent = browser_options.browser_user_agent_type
     self.assertEqual(expected_user_agent, actual_user_agent)
 
   def testPageStatesUserAgentType(self):
     self.assertUserAgentSetCorrectly(
         shared_page_state.SharedMobilePageState, 'mobile')
+    if platform_module.GetHostPlatform().GetOSName() == 'chromeos':

[nednguyen, 2017/04/25 12:54:44]

can you just change this flow to:
if platform_module.GetHostPlatform().GetOSName() == 'chromeos':
  
 self.assertUserAgentSetCorrectly(shared_page_state.SharedDesktopPageState,
'chromeos')
else:
 self.assert...('desktop')

[cywang, 2017/04/25 13:14:18]

Done.

+      device_type = 'chromeos'
+    else:
+      device_type = 'desktop'
     self.assertUserAgentSetCorrectly(
-        shared_page_state.SharedDesktopPageState, 'desktop')
+        shared_page_state.SharedDesktopPageState, device_type)
     self.assertUserAgentSetCorrectly(
         shared_page_state.SharedTabletPageState, 'tablet')
     self.assertUserAgentSetCorrectly(
         shared_page_state.Shared10InchTabletPageState, 'tablet_10_inch')
     self.assertUserAgentSetCorrectly(
         shared_page_state.SharedPageState, None)
 
   def testBrowserStartupURLSetCorrectly(self):
     story_set = story_module.StorySet()
     google_page = page.Page(
         'http://www.google.com',
         startup_url='http://www.google.com', page_set=story_set)
     example_page = page.Page(
         'https://www.example.com',
         startup_url='https://www.example.com', page_set=story_set)
     gmail_page = page.Page(
         'https://www.gmail.com',
         startup_url='https://www.gmail.com', page_set=story_set)
 
     for p in (google_page, example_page, gmail_page):
       story_set.AddStory(p)
 
     shared_state = shared_page_state.SharedPageState(
         DummyTest(), self.options, story_set)
 
     for p in (google_page, example_page, gmail_page):
       shared_state.WillRunStory(p)
       self.assertEquals(
           p.startup_url, self.options.browser_options.startup_url)