chrome/browser/gtk/options/geolocation_content_exceptions_window.cc - Issue 2838037: Introduce RemoveRowTableModel interface, let GeolocationExceptionsTableModel derive from it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/options/geolocation_content_exceptions_window.cc

Issue 2838037: Introduce RemoveRowTableModel interface, let GeolocationExceptionsTableModel derive from it. (Closed)

Patch Set: '' Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_exceptions_table_model_unittest.cc ('k') | chrome/browser/remove_rows_table_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/gtk/options/geolocation_content_exceptions_window.cc

diff --git a/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc b/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc

index 79cfe2051d17be2987d48f17ee82565785371f65..e1e28e435641ea5c7643ba2ab7b95b1f07feccce 100644

--- a/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc

+++ b/chrome/browser/gtk/options/geolocation_content_exceptions_window.cc

@@ -141,7 +141,7 @@ void GeolocationContentExceptionsWindow::UpdateButtonState() {

GeolocationExceptionsTableModel::Rows rows;

GetSelectedRows(&rows);

- gtk_widget_set_sensitive(remove_button_, model_->CanRemoveExceptions(rows));

+ gtk_widget_set_sensitive(remove_button_, model_->CanRemoveRows(rows));

gtk_widget_set_sensitive(remove_all_button_, row_count > 0);

}

@@ -156,7 +156,7 @@ void GeolocationContentExceptionsWindow::GetSelectedRows(

void GeolocationContentExceptionsWindow::Remove(GtkWidget* widget) {

GeolocationExceptionsTableModel::Rows rows;

GetSelectedRows(&rows);

- model_->RemoveExceptions(rows);

+ model_->RemoveRows(rows);

UpdateButtonState();

}