Issue 283803002: Add EventRewriterController as an aura::Env observer.

Issue 283803002: Add EventRewriterController as an aura::Env observer. (Closed)

Created:
6 years, 7 months ago by kpschoedel

Modified:
6 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add EventRewriterController as an aura::Env observer. Key mapping was not working when the cursor was on an external monitor added after Chrome started. BUG=371496 R=derat@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270180

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move AddObserver() to EventRewriterController() constructor. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/events/event_rewriter_controller.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

https://codereview.chromium.org/283803002/diff/1/chrome/browser/chromeos/events/event_rewriter_controller.cc File chrome/browser/chromeos/events/event_rewriter_controller.cc (right): https://codereview.chromium.org/283803002/diff/1/chrome/browser/chromeos/events/event_rewriter_controller.cc#newcode51 chrome/browser/chromeos/events/event_rewriter_controller.cc:51: aura::Env::GetInstance()->AddObserver(this); can you do this in the c'tor instead? ...

6 years, 7 months ago (2014-05-13 15:27:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/283803002/20001

6 years, 7 months ago (2014-05-13 17:20:28 UTC) #6

Message was sent while issue was closed.

Change committed as 270180

Expand Messages | Collapse Messages