ios/web/navigation/crw_session_controller.mm - Issue 2838003002: Fix missing back navigation item when pending item is displayed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/crw_session_controller.mm

Issue 2838003002: Fix missing back navigation item when pending item is displayed. (Closed)

Patch Set: To match desktop behavior: do not include pending item in session history Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/crw_session_controller.mm

diff --git a/ios/web/navigation/crw_session_controller.mm b/ios/web/navigation/crw_session_controller.mm

index 58d095a83c8377d39736ad1162c309865a44a407..275da0fa0448ff13c953bf7bbf7637161362d7e7 100644

--- a/ios/web/navigation/crw_session_controller.mm

+++ b/ios/web/navigation/crw_session_controller.mm

@@ -202,6 +202,14 @@ initiationType:(web::NavigationInitiationType)initiationType;

- (web::NavigationItemList)backwardItems {

web::NavigationItemList items;

+ // If the current navigation item is a transient item (e.g. SSL interstitial),

+ // the last committed item should also be considered part of the backward

+ // history.

+ if (self.transientItem) {

+ items.push_back(self.items[_lastCommittedItemIndex].get());

kkhorimoto 2017/04/26 10:50:37 Optional nit: items.push_back(self.lastCommittedIt

+ }

for (size_t index = _lastCommittedItemIndex; index > 0; --index) {

if (![self isRedirectTransitionForItemAtIndex:index])

items.push_back(self.items[index - 1].get());

« no previous file with comments | « no previous file | ios/web/navigation/crw_session_controller_unittest.mm » ('j') | no next file with comments »