Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: extensions/common/api/clipboard.idl

Issue 2837983002: Modify SetImageData to add additional items along with image data to save on clipboard. (Closed)
Patch Set: Make additional data items parameter optional and address other comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/clipboard.idl
diff --git a/extensions/common/api/clipboard.idl b/extensions/common/api/clipboard.idl
index 591be7e9412054dcb8d97aa65aa65540116827d5..0a9dfa73ebebffc19666a347059a044bc9e87cf7 100644
--- a/extensions/common/api/clipboard.idl
+++ b/extensions/common/api/clipboard.idl
@@ -12,6 +12,21 @@ namespace clipboard {
// Supported image types.
enum ImageType {png, jpeg};
+ enum DataItemType {text_plain, text_html};
Devlin 2017/05/17 16:08:44 prefer jsCasing
jennyz 2017/05/18 23:33:49 Done.
+
+ // Additional data item to be added along with the |image_data| to describe
+ // the |image_data|.
+ dictionary AdditionalDataItem {
+ // MIME type of the additional data item, supported types are:
Devlin 2017/05/17 16:08:44 "supported types" portion of this comment is out-d
jennyz 2017/05/18 23:33:49 Done.
+ // "text/plain" and "text/html".
+ DataItemType type;
+
+ // Content of the additional data item. Either the plain text string if
+ // |type| is "text/plain" or markup string if |type| is "text/html". The
+ // data can not exceed 2MB characters.
Devlin 2017/05/17 16:08:44 "2MB characters" doesn't make sense to me. We sho
jennyz 2017/05/18 23:33:49 Done.
+ DOMString data;
+ };
+
interface Events {
// Fired when clipboard data changes.
// Requires clipboard and clipboardRead permissions for adding listener to
@@ -28,11 +43,13 @@ namespace clipboard {
//
// |image_data|: The encoded image data.
// |type|: The type of image being passed.
+ // |additional_items|: Additional data items for describing image data.
// The callback is called with <code>chrome.runtime.lastError</code>
// set to error code if there is an error.
// Requires clipboard and clipboardWrite permissions.
static void setImageData(ArrayBuffer image_data,
ImageType type,
+ optional AdditionalDataItem[] additional_items,
Devlin 2017/05/17 16:08:44 jsStyle
jennyz 2017/05/18 23:33:49 Done.
SetImageDataCallback callback);
};
};

Powered by Google App Engine
This is Rietveld 408576698