Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: extensions/common/api/clipboard.idl

Issue 2837983002: Modify SetImageData to add additional items along with image data to save on clipboard. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/api/clipboard.idl
diff --git a/extensions/common/api/clipboard.idl b/extensions/common/api/clipboard.idl
index 591be7e9412054dcb8d97aa65aa65540116827d5..fc332f764f6422d455ceec5072f2dd6f0bac11e4 100644
--- a/extensions/common/api/clipboard.idl
+++ b/extensions/common/api/clipboard.idl
@@ -11,6 +11,18 @@
namespace clipboard {
// Supported image types.
enum ImageType {png, jpeg};
+
+ // Additional data item to be added along with the |image_data| to describe
+ // the |image_data|.
+ dictionary AdditionalDataItem {
+ // MIME type of the additional data item, supported types are:
+ // "text/plain" and "text/html".
Devlin 2017/04/26 18:20:15 if these are the only allowed types, why not an en
jennyz 2017/05/16 18:22:03 Done.
+ DOMString type;
+
+ // Content of the additional data item. Either the plain text string if
+ // |type| is "text/plain" or markup string if |type| is "text/html".
+ DOMString data;
Devlin 2017/04/26 18:20:15 From the implementation, I see that this has a lim
jennyz 2017/05/16 18:22:03 Done.
+ };
interface Events {
// Fired when clipboard data changes.
@@ -28,11 +40,13 @@ namespace clipboard {
//
// |image_data|: The encoded image data.
// |type|: The type of image being passed.
+ // |additional_items|: Additional data items for describing image data.
// The callback is called with <code>chrome.runtime.lastError</code>
// set to error code if there is an error.
// Requires clipboard and clipboardWrite permissions.
static void setImageData(ArrayBuffer image_data,
ImageType type,
+ AdditionalDataItem[] additional_items,
Devlin 2017/04/26 18:20:15 This is not a backwards compatible change, and wil
jennyz 2017/05/16 18:22:03 Mark the new parameter as optional.
SetImageDataCallback callback);
};
};

Powered by Google App Engine
This is Rietveld 408576698