Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2837963002: Fix for indirect recursion in resynthesizing function type aliases. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for indirect recursion in resynthesizing function type aliases. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/04ae172d33fce0c54888fd902ea954bad208a23b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +27 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-24 20:01:15 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-24 20:11:05 UTC) #2
scheglov
3 years, 8 months ago (2017-04-24 20:13:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04ae172d33fce0c54888fd902ea954bad208a23b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698