Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2837943006: [WIP] Support PerformanceResourceTiming for Service Worker Navigation Preload (Closed)

Created:
3 years, 8 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, michaeln, mlamouri+watch-content_chromium.org, panicker+watch_chromium.org, tzik, jsbell+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, blink-reviews-api_chromium.org, haraken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, shimazu+serviceworker_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support PerformanceResourceTiming for Service Worker Navigation Preload BUG=712809

Patch Set 1 #

Patch Set 2 : CORE_EXPORT WorkerGlobalScopePerformance #

Patch Set 3 : fix NetworkHandler::NavigationPreloadCompleted #

Patch Set 4 : small fix #

Patch Set 5 : add test #

Patch Set 6 : add chromium layouttest #

Patch Set 7 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -65 lines) Patch
M content/browser/devtools/protocol/network_handler.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 3 chunks +15 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resource-timing.https.html View 1 2 3 4 5 6 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resources/resource-timing-scope.py View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-preload/resources/resource-timing-worker.js View 1 2 3 4 5 6 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/navigation-preload-resource-timing.html View 1 2 3 4 5 6 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/resources/navigation-preload-resource-timing-scope.html View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/chromium/resources/navigation-preload-resource-timing-worker.js View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.cpp View 1 2 3 12 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceResourceTiming.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceResourceTiming.cpp View 1 2 3 13 chunks +27 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/timing/WorkerGlobalScopePerformance.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 1 2 3 4 5 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 1 2 3 4 4 chunks +38 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h View 1 2 3 3 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 5 chunks +19 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2835123005 Patch 20001

Messages

Total messages: 19 (19 generated)
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 07:14:40 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837943006/1
3 years, 8 months ago (2017-04-26 07:14:59 UTC) #2
horo
Description was changed from ========== Support PerformanceResourceTiming for Service Worker Navigation Preload BUG=712809 ========== to ...
3 years, 8 months ago (2017-04-26 07:35:14 UTC) #3
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 07:35:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837943006/20001
3 years, 8 months ago (2017-04-26 07:35:38 UTC) #5
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 08:29:43 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837943006/40001
3 years, 8 months ago (2017-04-26 08:29:55 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 10:09:37 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-26 10:09:38 UTC) #9
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-27 03:12:22 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837943006/60001
3 years, 8 months ago (2017-04-27 03:12:57 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-27 05:12:20 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-27 05:12:21 UTC) #13
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-27 06:49:49 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837943006/100001
3 years, 8 months ago (2017-04-27 06:50:02 UTC) #15
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-27 07:00:38 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837943006/120001
3 years, 8 months ago (2017-04-27 07:00:54 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-27 08:42:05 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 08:42:06 UTC) #19 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698