Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/Source/core/dom/NodeFilter.h

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)
Patch Set: templates.gni, etc. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/NodeFilter.h
diff --git a/third_party/WebKit/Source/core/dom/NodeFilter.h b/third_party/WebKit/Source/core/dom/NodeFilter.h
index 623334a54055f1111d1d92139062011656abd499..870b6a97fb3a0af5f9515d464e7b0fb37105c7c2 100644
--- a/third_party/WebKit/Source/core/dom/NodeFilter.h
+++ b/third_party/WebKit/Source/core/dom/NodeFilter.h
@@ -25,8 +25,6 @@
#ifndef NodeFilter_h
#define NodeFilter_h
-#include "bindings/core/v8/ExceptionState.h"
-#include "bindings/core/v8/ScriptWrappable.h"
#include "platform/heap/Handle.h"
namespace blink {
@@ -34,9 +32,8 @@ namespace blink {
// We never create NodeFilter instances.
// The IDL interface 'NodeFilter' is represented by V8NodeFilterCondition and a
// V8 value in Blink.
-class NodeFilter final : public GarbageCollected<NodeFilter>,
- public ScriptWrappable {
- DEFINE_WRAPPERTYPEINFO();
+class NodeFilter final {
+ STATIC_ONLY(NodeFilter);
public:
/**
@@ -66,16 +63,6 @@ class NodeFilter final : public GarbageCollected<NodeFilter>,
kShowDocumentFragment = 0x00000400,
kShowNotation = 0x00000800
};
-
- unsigned acceptNode(Node*, ExceptionState&) const {
- NOTREACHED();
- return kFilterReject;
- }
-
- DEFINE_INLINE_TRACE() {}
-
- private:
- NodeFilter() = delete;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698