third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py - Issue 2837923003: Make NodeFilter a legacy callback interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)

Patch Set: templates.gni, etc. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/code_generator_v8.py ('k') | third_party/WebKit/Source/bindings/scripts/utilities.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py

diff --git a/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py b/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py

index 4b759de70f90b8d283eae07a8b85645590db56dc..04e4e0e36c83b38af6c7a54c51973c7ecb7ee642 100755

--- a/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py

+++ b/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py

@@ -30,7 +30,7 @@ from utilities import get_file_contents

from utilities import get_interface_exposed_arguments

from utilities import get_interface_extended_attributes_from_idl

from utilities import idl_filename_to_interface_name

-from utilities import is_callback_interface_from_idl

+from utilities import is_non_legacy_callback_interface_from_idl

from utilities import read_file_to_list

from utilities import read_pickle_file

from utilities import should_generate_impl_file_from_idl

@@ -79,11 +79,9 @@ def record_global_constructors(idl_filename):

# An interface property is produced for every non-callback interface

# that does not have [NoInterfaceObject].

- # Callback interfaces with constants also have interface properties,

- # but there are none of these in Blink.

# http://heycam.github.io/webidl/#es-interfaces

if ((not should_generate_impl_file_from_idl(idl_file_contents)) or

- is_callback_interface_from_idl(idl_file_contents) or

+ is_non_legacy_callback_interface_from_idl(idl_file_contents) or

'NoInterfaceObject' in extended_attributes):

return