third_party/WebKit/Source/bindings/scripts/v8_types.py - Issue 2837923003: Make NodeFilter a legacy callback interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)

Patch Set: legacy_callback_interface.*.tmpl, etc. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_types.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py

index 28278b54a4d82079c5df2937d605f6dcd045ab05..e986398b797bc26638430afc634303c286e96e95 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py

@@ -523,7 +523,6 @@ V8_VALUE_TO_CPP_VALUE = {

'DOMString': '{v8_value}',

# Interface types

'FlexibleArrayBufferView': 'ToFlexibleArrayBufferView({isolate}, {v8_value}, {variable_name}, allocateFlexibleArrayBufferViewStorage({v8_value}))',

- 'NodeFilter': 'V8NodeFilterCondition::CreateOrNull({v8_value}, ScriptState::Current({isolate}))',

'Promise': 'ScriptPromise::Cast(ScriptState::Current({isolate}), {v8_value})',

'ScriptValue': 'ScriptValue(ScriptState::Current({isolate}), {v8_value})',

'Window': 'ToDOMWindow({isolate}, {v8_value})',