Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/dom/NodeFilter.idl

Issue 2837923003: Make NodeFilter a legacy callback interface. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/NodeFilter.idl
diff --git a/third_party/WebKit/Source/core/dom/NodeFilter.idl b/third_party/WebKit/Source/core/dom/NodeFilter.idl
index e9dc637aaa12681e5111ed7e2eaf9df26122045e..13d51beae81d771c09fac38986d16ad6a46ec68c 100644
--- a/third_party/WebKit/Source/core/dom/NodeFilter.idl
+++ b/third_party/WebKit/Source/core/dom/NodeFilter.idl
@@ -20,10 +20,9 @@
// https://dom.spec.whatwg.org/#interface-nodefilter
-// FIXME: NodeFilter should be a callback interface. crbug.com/462946
[
DependentLifetime,
-] interface NodeFilter {
+] callback interface NodeFilter {
// Constants for acceptNode()
const unsigned short FILTER_ACCEPT = 1;
const unsigned short FILTER_REJECT = 2;
« third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698