Make NodeFilter a legacy callback interface.

third_party/WebKit/Source/bindings/scripts/code_generator_v8.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 163 matching lines @@
                 definitions.dictionaries[definition_name])
         raise ValueError('%s is not in IDL definitions' % definition_name)
 
     def generate_interface_code(self, definitions, interface_name, interface):
         interface_info = self.info_provider.interfaces_info[interface_name]
         full_path = interface_info.get('full_path')
         component = idl_filename_to_component(full_path)
         include_paths = interface_info.get('dependencies_include_paths')
 
         # Select appropriate Jinja template and contents function
-        if interface.is_callback:
+        if interface.is_callback and len(interface.constants) > 0:

[bashi, 2017/04/28 06:28:34]

Could you add a comment why we use len(interface.constants) to detect legacy
callback interface?

[tkent, 2017/04/28 09:22:01]

Done.

+            header_template_filename = 'legacy_callback_interface.h.tmpl'
+            cpp_template_filename = 'legacy_callback_interface.cpp.tmpl'
+            interface_context = v8_callback_interface.legacy_callback_interface_context
+        elif interface.is_callback:
             header_template_filename = 'callback_interface.h.tmpl'
             cpp_template_filename = 'callback_interface.cpp.tmpl'
             interface_context = v8_callback_interface.callback_interface_context
         elif interface.is_partial:
             interface_context = v8_interface.interface_context
             header_template_filename = 'partial_interface.h.tmpl'
             cpp_template_filename = 'partial_interface.cpp.tmpl'
             interface_name += 'Partial'
             assert component == 'core'
             component = 'modules'
@@ skipping 190 matching lines @@
         outputs = set()
         for callback_function_dict in callback_functions.itervalues():
             if callback_function_dict['component_dir'] != self.target_component:
                 continue
             callback_function = callback_function_dict['callback_function']
             if 'Custom' in callback_function.extended_attributes:
                 continue
             path = callback_function_dict['full_path']
             outputs.update(self.generate_code_internal(callback_function, path))
         return outputs