Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: components/exo/shell_surface.h

Issue 2837903002: Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. (Closed)
Patch Set: cleanup Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/exo/shell_surface.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_EXO_SHELL_SURFACE_H_ 5 #ifndef COMPONENTS_EXO_SHELL_SURFACE_H_
6 #define COMPONENTS_EXO_SHELL_SURFACE_H_ 6 #define COMPONENTS_EXO_SHELL_SURFACE_H_
7 7
8 #include <cstdint> 8 #include <cstdint>
9 #include <deque> 9 #include <deque>
10 #include <memory> 10 #include <memory>
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 // Overridden from WMHelper::DisplayConfigurationObserver: 269 // Overridden from WMHelper::DisplayConfigurationObserver:
270 void OnDisplayConfigurationChanged() override; 270 void OnDisplayConfigurationChanged() override;
271 271
272 // Overridden from ui::EventHandler: 272 // Overridden from ui::EventHandler:
273 void OnKeyEvent(ui::KeyEvent* event) override; 273 void OnKeyEvent(ui::KeyEvent* event) override;
274 void OnMouseEvent(ui::MouseEvent* event) override; 274 void OnMouseEvent(ui::MouseEvent* event) override;
275 275
276 // Overridden from ui::AcceleratorTarget: 276 // Overridden from ui::AcceleratorTarget:
277 bool AcceleratorPressed(const ui::Accelerator& accelerator) override; 277 bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
278 278
279 aura::Window* shadow_overlay() { return shadow_overlay_; } 279 aura::Window* shadow_overlay() { return shadow_overlay_.get(); }
280 aura::Window* shadow_underlay() { return shadow_underlay_; } 280 aura::Window* shadow_underlay() { return shadow_underlay_.get(); }
281 281
282 Surface* surface_for_testing() { return surface_; } 282 Surface* surface_for_testing() { return surface_; }
283 283
284 private: 284 private:
285 class ScopedConfigure; 285 class ScopedConfigure;
286 class ScopedAnimationsDisabled; 286 class ScopedAnimationsDisabled;
287 287
288 // Surface state associated with each configure request. 288 // Surface state associated with each configure request.
289 struct Config { 289 struct Config {
290 uint32_t serial; 290 uint32_t serial;
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 base::Closure surface_destroyed_callback_; 358 base::Closure surface_destroyed_callback_;
359 StateChangedCallback state_changed_callback_; 359 StateChangedCallback state_changed_callback_;
360 ConfigureCallback configure_callback_; 360 ConfigureCallback configure_callback_;
361 ScopedConfigure* scoped_configure_ = nullptr; 361 ScopedConfigure* scoped_configure_ = nullptr;
362 bool ignore_window_bounds_changes_ = false; 362 bool ignore_window_bounds_changes_ = false;
363 gfx::Vector2d origin_offset_; 363 gfx::Vector2d origin_offset_;
364 gfx::Vector2d pending_origin_offset_; 364 gfx::Vector2d pending_origin_offset_;
365 gfx::Vector2d pending_origin_offset_accumulator_; 365 gfx::Vector2d pending_origin_offset_accumulator_;
366 int resize_component_ = HTCAPTION; // HT constant (see ui/base/hit_test.h) 366 int resize_component_ = HTCAPTION; // HT constant (see ui/base/hit_test.h)
367 int pending_resize_component_ = HTCAPTION; 367 int pending_resize_component_ = HTCAPTION;
368 aura::Window* shadow_overlay_ = nullptr; 368 std::unique_ptr<aura::Window> shadow_overlay_;
369 aura::Window* shadow_underlay_ = nullptr; 369 std::unique_ptr<aura::Window> shadow_underlay_;
370 std::unique_ptr<ui::EventHandler> shadow_underlay_event_handler_; 370 std::unique_ptr<ui::EventHandler> shadow_underlay_event_handler_;
371 gfx::Rect shadow_content_bounds_; 371 gfx::Rect shadow_content_bounds_;
372 float shadow_background_opacity_ = 1.0; 372 float shadow_background_opacity_ = 1.0;
373 std::deque<Config> pending_configs_; 373 std::deque<Config> pending_configs_;
374 std::unique_ptr<ash::WindowResizer> resizer_; 374 std::unique_ptr<ash::WindowResizer> resizer_;
375 std::unique_ptr<ScopedAnimationsDisabled> scoped_animations_disabled_; 375 std::unique_ptr<ScopedAnimationsDisabled> scoped_animations_disabled_;
376 int top_inset_height_ = 0; 376 int top_inset_height_ = 0;
377 int pending_top_inset_height_ = 0; 377 int pending_top_inset_height_ = 0;
378 bool shadow_underlay_in_surface_ = true; 378 bool shadow_underlay_in_surface_ = true;
379 bool pending_shadow_underlay_in_surface_ = true;
379 bool system_modal_ = false; 380 bool system_modal_ = false;
380 381
381 DISALLOW_COPY_AND_ASSIGN(ShellSurface); 382 DISALLOW_COPY_AND_ASSIGN(ShellSurface);
382 }; 383 };
383 384
384 } // namespace exo 385 } // namespace exo
385 386
386 #endif // COMPONENTS_EXO_SHELL_SURFACE_H_ 387 #endif // COMPONENTS_EXO_SHELL_SURFACE_H_
OLDNEW
« no previous file with comments | « no previous file | components/exo/shell_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698