Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/loader.cc

Issue 2837873005: Fix some assertion failures on Fuchsia (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/isolate_data.h ('K') | « runtime/bin/isolate_data.h ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/loader.cc
diff --git a/runtime/bin/loader.cc b/runtime/bin/loader.cc
index de82be482639d729dd82c52a08cf82a723711f37..dc664dfabdca0b21669ebbcc6ab2db770a090b1d 100644
--- a/runtime/bin/loader.cc
+++ b/runtime/bin/loader.cc
@@ -550,7 +550,10 @@ Dart_Handle Loader::SendAndProcessReply(intptr_t tag,
IsolateData* isolate_data =
reinterpret_cast<IsolateData*>(Dart_CurrentIsolateData());
ASSERT(isolate_data != NULL);
+#ifndef TARGET_OS_FUCHSIA
+ // TODO(29458): Enable on Fuchsia.
ASSERT(!isolate_data->HasLoader());
+#endif
Loader* loader = NULL;
// Setup the loader. The constructor does a bunch of leg work.
« runtime/bin/isolate_data.h ('K') | « runtime/bin/isolate_data.h ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698