media/base/test_helpers.cc - Issue 2837863004: Use base::OneShotTimer instead of base::Timer(false, false)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/test_helpers.cc

Issue 2837863004: Use base::OneShotTimer instead of base::Timer(false, false)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/test_helpers.cc

diff --git a/media/base/test_helpers.cc b/media/base/test_helpers.cc

index 2a0c3211293e6709d86de955fbdc2c015d16e075..0434863db99d6efbd2074bb2193133f3f507d1b9 100644

--- a/media/base/test_helpers.cc

+++ b/media/base/test_helpers.cc

@@ -98,7 +98,7 @@ void WaitableMessageLoopEvent::RunAndWaitForStatus(PipelineStatus expected) {

}

run_loop_.reset(new base::RunLoop());

- base::Timer timer(false, false);

+ base::OneShotTimer timer;

timer.Start(

FROM_HERE, timeout_,

base::Bind(&WaitableMessageLoopEvent::OnTimeout, base::Unretained(this)));