Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2837743002: Issue 29432. Instantiate the redirect constructor with the in-scope type arguments. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 29432. Instantiate the redirect constructor with the in-scope type arguments. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/29432 Committed: https://github.com/dart-lang/sdk/commit/04b40ad15dc242f78a70e6b4700a551c5107a154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -81 lines) Patch
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 3 chunks +36 lines, -19 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 3 chunks +73 lines, -62 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-23 21:50:58 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-24 13:18:38 UTC) #2
scheglov
3 years, 8 months ago (2017-04-24 15:54:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04b40ad15dc242f78a70e6b4700a551c5107a154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698