Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: content/common/frame.mojom

Issue 2837683002: Remove opener URLs from CreateNewWindowParams. (Closed)
Patch Set: Fix browsertest. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/frame.mojom
diff --git a/content/common/frame.mojom b/content/common/frame.mojom
index c864e2f6efec7cc37e4ec935d184d18233026bbd..613037782fd5f7f2fc12bf2796fe9c94df6b8af2 100644
--- a/content/common/frame.mojom
+++ b/content/common/frame.mojom
@@ -41,9 +41,6 @@ interface FrameFactory {
CreateFrame(int32 frame_routing_id, Frame& frame, FrameHostInterfaceBroker host);
};
-// TODO(csharrison): Clean up this struct. Some of the entries (like
-// opener_top_level_frame_url) are better suited to be computed in the browser
-// process. See http://crbug.com/674307.
struct CreateNewWindowParams {
// True if this open request came in the context of a user gesture.
bool user_gesture;
@@ -58,15 +55,6 @@ struct CreateNewWindowParams {
// has been specified). UTF8 encoded string.
string frame_name;
- // The URL of the frame initiating the open.
- url.mojom.Url opener_url;
-
- // The URL of the top frame containing the opener.
- url.mojom.Url opener_top_level_frame_url;
-
- // The security origin of the frame initiating the open.
- url.mojom.Url opener_security_origin;
-
// Whether the opener will be suppressed in the new window, in which case
// scripting the new window is not allowed.
bool opener_suppressed;
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698