components/bookmarks/managed/managed_bookmark_service.cc - Issue 2837643002: [Bookmarks] Remove side drawer and introduce root folder view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/managed/managed_bookmark_service.cc

Issue 2837643002: [Bookmarks] Remove side drawer and introduce root folder view (Closed)

Patch Set: Changes from dfalcantara@ review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/managed/managed_bookmark_service.cc

diff --git a/components/bookmarks/managed/managed_bookmark_service.cc b/components/bookmarks/managed/managed_bookmark_service.cc

index 9d820059a0504921cf8da9331802e7620a62997b..c7c356eeeb0ba40e48aabbaa854c012eb2246cf2 100644

--- a/components/bookmarks/managed/managed_bookmark_service.cc

+++ b/components/bookmarks/managed/managed_bookmark_service.cc

@@ -148,7 +148,7 @@ bool ManagedBookmarkService::CanSyncNode(const BookmarkNode* node) {

bool ManagedBookmarkService::CanBeEditedByUser(const BookmarkNode* node) {

return !IsDescendantOf(node, managed_node_) &&

- !IsDescendantOf(node, supervised_node_);

+ !IsDescendantOf(node, supervised_node_) && !node->is_root();

sky 2017/04/24 19:22:25 How about using !is_permanent_node? (on the model)

Theresa 2017/04/24 20:19:10 Done.

}

void ManagedBookmarkService::Shutdown() {

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkTest.java ('k') | no next file » | no next file with comments »