Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: media/filters/fake_video_decoder.cc

Issue 2837613004: media: Support better decoder switching (Closed)
Patch Set: Mock*Decoder name Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/fake_video_decoder.cc
diff --git a/media/filters/fake_video_decoder.cc b/media/filters/fake_video_decoder.cc
index 06c4e7fe8946b81047e192cf48de5e641091efb0..bac7510ee727f90dc416d049e9f145e7ac19f5fc 100644
--- a/media/filters/fake_video_decoder.cc
+++ b/media/filters/fake_video_decoder.cc
@@ -23,12 +23,12 @@ FakeVideoDecoder::FakeVideoDecoder(const std::string& decoder_name,
total_bytes_decoded_(0),
fail_to_initialize_(false),
weak_factory_(this) {
- DVLOG(1) << __func__;
+ DVLOG(1) << decoder_name_ << ": " << __func__;
DCHECK_GE(decoding_delay, 0);
}
FakeVideoDecoder::~FakeVideoDecoder() {
- DVLOG(1) << __func__;
+ DVLOG(1) << decoder_name_ << ": " << __func__;
DCHECK(thread_checker_.CalledOnValidThread());
if (state_ == STATE_UNINITIALIZED)
@@ -57,7 +57,7 @@ void FakeVideoDecoder::Initialize(const VideoDecoderConfig& config,
CdmContext* cdm_context,
const InitCB& init_cb,
const OutputCB& output_cb) {
- DVLOG(1) << __func__;
+ DVLOG(1) << decoder_name_ << ": " << __func__;
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(config.IsValidConfig());
DCHECK(held_decode_callbacks_.empty())
@@ -82,9 +82,11 @@ void FakeVideoDecoder::Initialize(const VideoDecoderConfig& config,
}
if (fail_to_initialize_) {
+ DVLOG(1) << decoder_name_ << ": Initialization failed.";
state_ = STATE_ERROR;
init_cb_.RunOrHold(false);
} else {
+ DVLOG(1) << decoder_name_ << ": Initialization succeeded.";
state_ = STATE_NORMAL;
init_cb_.RunOrHold(true);
}

Powered by Google App Engine
This is Rietveld 408576698