Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/video_decoder.h

Issue 2837613004: media: Support better decoder switching (Closed)
Patch Set: update GetDisplayName() comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mock_filters.cc ('k') | media/base/video_decoder_config.h » ('j') | media/filters/audio_decoder_selector_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder.h
diff --git a/media/base/video_decoder.h b/media/base/video_decoder.h
index 95fd7fc3edd9f08a81a881c1a36e89a0c784c6f9..30d4ddf8713a0c41815073d26952beb543d6a7d5 100644
--- a/media/base/video_decoder.h
+++ b/media/base/video_decoder.h
@@ -44,7 +44,10 @@ class MEDIA_EXPORT VideoDecoder {
// depends on |this|.
virtual ~VideoDecoder();
- // Returns the name of the decoder for logging purpose.
+ // Returns the name of the decoder for logging and decoder selection purposes.
+ // This name should be available immediately after construction (e.g. before
+ // Initialize() is called). It should also be stable in the sense that the
+ // name does not change across multiple constructions.
virtual std::string GetDisplayName() const = 0;
// Initializes a VideoDecoder with the given |config|, executing the
« no previous file with comments | « media/base/mock_filters.cc ('k') | media/base/video_decoder_config.h » ('j') | media/filters/audio_decoder_selector_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698