Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: components/safe_browsing/common/safebrowsing_messages.h

Issue 2837603002: Content API changes to improve DOM stitching in ThreatDetails code. (Closed)
Patch Set: Use explicitly-sized int types in IPC definition Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/common/safebrowsing_messages.h
diff --git a/components/safe_browsing/common/safebrowsing_messages.h b/components/safe_browsing/common/safebrowsing_messages.h
index 1e03fa10f4504a6ebd48dd7a2ea3e7e6c4ab1167..400201d0d2d2de28da0427811372dd271965f0af 100644
--- a/components/safe_browsing/common/safebrowsing_messages.h
+++ b/components/safe_browsing/common/safebrowsing_messages.h
@@ -4,6 +4,7 @@
// Multiply-included message file, so no include guard.
+#include <stdint.h>
#include <string>
#include <vector>
@@ -17,7 +18,7 @@
// A node is essentially a frame.
IPC_STRUCT_BEGIN(SafeBrowsingHostMsg_ThreatDOMDetails_Node)
// A unique ID for this node, unique to the current Render Frame.
- IPC_STRUCT_MEMBER(int, node_id)
+ IPC_STRUCT_MEMBER(int32_t, node_id)
// URL of this resource. Can be empty.
IPC_STRUCT_MEMBER(GURL, url)
@@ -30,16 +31,21 @@ IPC_STRUCT_BEGIN(SafeBrowsingHostMsg_ThreatDOMDetails_Node)
IPC_STRUCT_MEMBER(GURL, parent)
// The unique ID of the parent node. Can be 0 if this is the top node.
- IPC_STRUCT_MEMBER(int, parent_node_id)
+ IPC_STRUCT_MEMBER(int32_t, parent_node_id)
// children of this node. Can be emtpy.
IPC_STRUCT_MEMBER(std::vector<GURL>, children)
// The unique IDs of the child nodes. Can be empty if there are no children.
- IPC_STRUCT_MEMBER(std::vector<int>, child_node_ids)
+ IPC_STRUCT_MEMBER(std::vector<int32_t>, child_node_ids)
// The node's attributes, as a collection of name-value pairs.
IPC_STRUCT_MEMBER(std::vector<safe_browsing::AttributeNameValue>, attributes)
+
+ // If this node represents a frame or iframe, then this field is set to the
+ // routing ID of the local or remote frame in this renderer process that is
+ // responsible for rendering the contents of this frame (to handle OOPIFs).
+ IPC_STRUCT_MEMBER(int32_t, child_frame_routing_id)
IPC_STRUCT_END()
// SafeBrowsing client-side detection messages sent from the renderer to the
« no previous file with comments | « components/safe_browsing/browser/threat_details.cc ('k') | components/safe_browsing/renderer/threat_dom_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698