components/safe_browsing/common/safebrowsing_messages.h - Issue 2837603002: Content API changes to improve DOM stitching in ThreatDetails code.

Side by Side Diff: components/safe_browsing/common/safebrowsing_messages.h

Issue 2837603002: Content API changes to improve DOM stitching in ThreatDetails code. (Closed)

Patch Set: Set output pointers correctly Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/safe_browsing/threat_details_unittest.cc ('K') | « chrome/browser/safe_browsing/threat_details_unittest.cc ('k') | components/safe_browsing/renderer/threat_dom_details.cc » ('j') | components/safe_browsing/renderer/threat_dom_details.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included message file, so no include guard.	5 // Multiply-included message file, so no include guard.

6	6

7 #include <string>	7 #include <string>

8 #include <vector>	8 #include <vector>

9	9

10 #include "components/safe_browsing/common/safebrowsing_types.h"	10 #include "components/safe_browsing/common/safebrowsing_types.h"

(...skipping 22 matching lines...) Expand all Loading...
33 IPC_STRUCT_MEMBER(int, parent_node_id)	33 IPC_STRUCT_MEMBER(int, parent_node_id)

34	34

35 // children of this node. Can be emtpy.	35 // children of this node. Can be emtpy.

36 IPC_STRUCT_MEMBER(std::vector<GURL>, children)	36 IPC_STRUCT_MEMBER(std::vector<GURL>, children)

37	37

38 // The unique IDs of the child nodes. Can be empty if there are no children.	38 // The unique IDs of the child nodes. Can be empty if there are no children.

39 IPC_STRUCT_MEMBER(std::vector<int>, child_node_ids)	39 IPC_STRUCT_MEMBER(std::vector<int>, child_node_ids)

40	40

41 // The node's attributes, as a collection of name-value pairs.	41 // The node's attributes, as a collection of name-value pairs.

42 IPC_STRUCT_MEMBER(std::vector<safe_browsing::AttributeNameValue>, attributes)	42 IPC_STRUCT_MEMBER(std::vector<safe_browsing::AttributeNameValue>, attributes)

	43

	44 // If this node represents a Frame or Iframe, then this field is set to the
	Charlie Reis 2017/05/05 21:03:07 nit: frame or iframe nit: frame or iframe lpz 2017/05/10 14:21:09 Done. Show quoted text On 2017/05/05 21:03:07, Charlie Reis wrote: > nit: frame or iframe Done.
	45 // routing_id of the renderer that is responsible for rendering the contents
	Charlie Reis 2017/05/05 21:03:07 nit: routing ID of the local or remote frame in th nit: routing ID of the local or remote frame in this renderer process that is (Routing IDs identify frames/proxies, not renderers.) lpz 2017/05/10 14:21:09 Done. Show quoted text On 2017/05/05 21:03:07, Charlie Reis wrote: > nit: routing ID of the local or remote frame in this renderer process that is > > (Routing IDs identify frames/proxies, not renderers.) Done.
	46 // of this frame (to handle OOPIFs).

	47 IPC_STRUCT_MEMBER(int, other_frame_routing_id)
	Charlie Reis 2017/05/05 21:03:07 child_frame_routing_id child_frame_routing_id lpz 2017/05/10 14:21:09 Done. Show quoted text On 2017/05/05 21:03:07, Charlie Reis wrote: > child_frame_routing_id Done.
43 IPC_STRUCT_END()	48 IPC_STRUCT_END()

44	49

45 // SafeBrowsing client-side detection messages sent from the renderer to the	50 // SafeBrowsing client-side detection messages sent from the renderer to the

46 // browser.	51 // browser.

47	52

48 // Send part of the DOM to the browser, to be used in a threat report.	53 // Send part of the DOM to the browser, to be used in a threat report.

49 IPC_MESSAGE_ROUTED1(SafeBrowsingHostMsg_ThreatDOMDetails,	54 IPC_MESSAGE_ROUTED1(SafeBrowsingHostMsg_ThreatDOMDetails,

50 std::vector<SafeBrowsingHostMsg_ThreatDOMDetails_Node>)	55 std::vector<SafeBrowsingHostMsg_ThreatDOMDetails_Node>)

51	56

52 #if defined(FULL_SAFE_BROWSING)	57 #if defined(FULL_SAFE_BROWSING)

(...skipping 17 matching lines...) Expand all Loading...
70 // The string is an encoded safe_browsing::ClientSideModel protocol buffer, or	75 // The string is an encoded safe_browsing::ClientSideModel protocol buffer, or

71 // empty to disable client-side phishing detection for this renderer.	76 // empty to disable client-side phishing detection for this renderer.

72 IPC_MESSAGE_CONTROL1(SafeBrowsingMsg_SetPhishingModel,	77 IPC_MESSAGE_CONTROL1(SafeBrowsingMsg_SetPhishingModel,

73 std::string /* encoded ClientSideModel proto */)	78 std::string /* encoded ClientSideModel proto */)

74	79

75 // Tells the renderer to begin phishing detection for the given toplevel URL	80 // Tells the renderer to begin phishing detection for the given toplevel URL

76 // which it has started loading.	81 // which it has started loading.

77 IPC_MESSAGE_ROUTED1(SafeBrowsingMsg_StartPhishingDetection,	82 IPC_MESSAGE_ROUTED1(SafeBrowsingMsg_StartPhishingDetection,

78 GURL)	83 GURL)

79 #endif	84 #endif

OLD	NEW