Content API changes to improve DOM stitching in ThreatDetails code.

content/public/browser/render_frame_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_
 
 #include <string>
 
 #include "base/callback_forward.h"
@@ skipping 45 matching lines @@
 #if defined(OS_ANDROID)
   // Globally allows for injecting JavaScript into the main world. This feature
   // is present only to support Android WebView and must not be used in other
   // configurations.
   static void AllowInjectingJavaScriptForAndroidWebView();
 #endif
 
   // Returns a RenderFrameHost given its accessibility tree ID.
   static RenderFrameHost* FromAXTreeID(int ax_tree_id);
 
+  static int LookupOtherFrameTreeNodeId(int process_id, int routing_id);

[dmazzoni, 2017/04/21 15:48:48]

What does "Other" mean in this context?

I think a more natural API would be something like:

static RenderFrameHost* FromProcessIdAndRoutingId(int process_id, int
routing_id)

[lpz, 2017/05/02 19:36:24]

Renamed this function to be more generic.

For "other", I just used reused the wording from the safe browsing code
(other_frame_routing_id), where other refers to the fact that the contents of an
iframe are in some "other" renderer from the one that sees the iframe element.

As for returning a RenderFrameHost*, how would we support the case where the
{pid,rid} pair points to a RenderFrameProxyHost?

[dmazzoni, 2017/05/05 17:32:28]

Every RenderFrameProxyHost has an associated RenderFrameHost
for the process that actually hosts that frame, so you could
use that as the canonical one.

[lpz, 2017/05/10 14:21:08]

Done.

+
   ~RenderFrameHost() override {}
 
   // Returns the route id for this frame.
   virtual int GetRoutingID() = 0;
 
   // Returns the accessibility tree ID for this RenderFrameHost.
   virtual int GetAXTreeID() = 0;
 
   // Returns the SiteInstance grouping all RenderFrameHosts that have script
   // access to this RenderFrameHost, and must therefore live in the same
@@ skipping 179 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class RenderFrameHostImpl;
   RenderFrameHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RENDER_FRAME_HOST_H_