Content API changes to improve DOM stitching in ThreatDetails code.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 1045 matching lines @@
 // static
 void RenderFrame::ForEach(RenderFrameVisitor* visitor) {
   FrameMap* frames = g_frame_map.Pointer();
   for (FrameMap::iterator it = frames->begin(); it != frames->end(); ++it) {
     if (!visitor->Visit(it->second))
       return;
   }
 }
 
 // static
+int RenderFrame::GetRoutingIdForWebFrame(blink::WebFrame* web_frame) {
+  return GetRoutingIdForFrameOrProxy(web_frame);

[Charlie Reis, 2017/05/15 20:23:14]

Did you decide not to go with Dominic's suggestion to replace
GetRoutingIdForFrameOrProxy with RenderFrame::GetRoutingIdForWebFrame, or did
that just fall between the cracks?  Seems like a reasonable change to me.

[lpz, 2017/05/16 15:19:57]

Ahh, I missed that comment. Thanks, done.

Btw, the only other function in web_frame_utils
(GetWebFrameFromRoutingIdForFrameOrProxy) seems to be unused, so that whole file
can probably be deleted. But I'd prefer to leave that for another CL.

[Charlie Reis, 2017/05/16 16:34:08]

Ah, nice!  Yes, we can remove that after this CL lands.

+}
+
+// static
 RenderFrameImpl* RenderFrameImpl::FromWebFrame(blink::WebFrame* web_frame) {
   FrameMap::iterator iter = g_frame_map.Get().find(web_frame);
   if (iter != g_frame_map.Get().end())
     return iter->second;
   return NULL;
 }
 
 // static
 void RenderFrameImpl::InstallCreateHook(
     CreateRenderFrameImplFunction create_render_frame_impl) {
@@ skipping 5995 matching lines @@
       policy(info.default_policy),
       replaces_current_history_item(info.replaces_current_history_item),
       history_navigation_in_new_child_frame(
           info.is_history_navigation_in_new_child_frame),
       client_redirect(info.is_client_redirect),
       cache_disabled(info.is_cache_disabled),
       form(info.form),
       source_location(info.source_location) {}
 
 }  // namespace content