Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(507)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/browser/safe_browsing/DEPS
Issue
2837603002
:
Content API changes to improve DOM stitching in ThreatDetails code. (Closed)
Patch Set: Sync and small unittest tweak
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/safe_browsing/DEPS
chrome/browser/safe_browsing/threat_details_unittest.cc
components/safe_browsing/browser/threat_details.h
components/safe_browsing/browser/threat_details.cc
components/safe_browsing/common/safebrowsing_messages.h
components/safe_browsing/renderer/threat_dom_details.cc
content/browser/frame_host/render_frame_host_impl.cc
content/public/browser/render_frame_host.h
content/public/renderer/render_frame.h
content/renderer/render_frame_impl.cc
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
chrome/browser/safe_browsing/threat_details_unittest.cc »
('j') |
chrome/browser/safe_browsing/threat_details_unittest.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2 "+mojo",
2 "+mojo",
3 "+components/chrome_cleaner",
3 "+components/chrome_cleaner",
4
"+content/test/test_render_frame_host.h",
Charlie Reis
2017/05/12 21:40:50
chrome/ isn't allowed to depend on non-public cont
chrome/ isn't allowed to depend on non-public content directories. See my comment below on how to fix.
lpz
2017/05/15 18:49:07
Done.
Show quoted text
On 2017/05/12 21:40:50, Charlie Reis wrote: > chrome/ isn't allowed to depend on non-public content directories. See my > comment below on how to fix.
Done.
4 ]
5 ]
OLD
NEW
« no previous file with comments
|
« no previous file
|
chrome/browser/safe_browsing/threat_details_unittest.cc »
('j') |
chrome/browser/safe_browsing/threat_details_unittest.cc »
('J')
Issue 2837603002: Content API changes to improve DOM stitching in ThreatDetails code. (Closed)
Created 3 years, 8 months ago by lpz
Modified 3 years, 7 months ago
Reviewers: dmazzoni, Charlie Reis, Nathan Parker, estark
Base URL:
Comments: 118
This is Rietveld
408576698