Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: third_party/WebKit/Source/web/tests/TouchActionTest.cpp

Issue 2837593002: Nuked WebFrameImplBase. (Closed)
Patch Set: Switched to static methods. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/TouchActionTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/TouchActionTest.cpp b/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
index 5d4272b3015d4dd936cfc9ca8e343b35cf3bdde1..fd41d0a12bb274aada574c6e0cf8e8b82c5b7dab 100644
--- a/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
+++ b/third_party/WebKit/Source/web/tests/TouchActionTest.cpp
@@ -54,7 +54,6 @@
#include "public/web/WebViewClient.h"
#include "public/web/WebWidgetClient.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "web/WebFrameImplBase.h"
#include "web/WebViewImpl.h"
#include "web/tests/FrameTestHelpers.h"
@@ -300,8 +299,8 @@ void TouchActionTest::RunTestOnTree(
<< ").";
std::string failure_context_pos = context_stream.str();
- LocalFrame* main_frame = static_cast<LocalFrame*>(
- web_view->MainFrame()->ToImplBase()->GetFrame());
+ LocalFrame* main_frame =
+ static_cast<LocalFrame*>(WebFrame::CoreFrame(web_view->MainFrame()));
dcheng 2017/04/26 11:45:35 Nit: ToLocalFrame() instead of static_cast while w
mustaq 2017/04/26 18:12:48 Done.
FrameView* main_frame_view = main_frame->View();
IntRect visible_rect = WindowClipRect(*main_frame_view);
ASSERT_TRUE(visible_rect.Contains(window_point))

Powered by Google App Engine
This is Rietveld 408576698