Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 2837593002: Nuked WebFrameImplBase. (Closed)
Patch Set: Replaced non-null params with refs. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/web/WebView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebFrame.h
diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h
index 9dfb4fb51943f0750822efedb65ecf46311b0163..804dfd2fe496960fd5466fc7b85ef2e0dbc5f3ad 100644
--- a/third_party/WebKit/public/web/WebFrame.h
+++ b/third_party/WebKit/public/web/WebFrame.h
@@ -52,6 +52,7 @@ namespace blink {
class Frame;
class OpenedFrameTracker;
+class Page;
class Visitor;
class WebAssociatedURLLoader;
struct WebAssociatedURLLoaderOptions;
@@ -60,7 +61,6 @@ class WebData;
class WebDataSource;
class WebDocument;
class WebElement;
-class WebFrameImplBase;
class WebLocalFrame;
class WebPerformance;
class WebRemoteFrame;
@@ -417,21 +417,18 @@ class WebFrame {
// text form. This is used only by layout tests.
virtual WebString LayerTreeAsText(bool show_debug_info = false) const = 0;
- virtual WebFrameImplBase* ToImplBase() = 0;
- // TODO(dcheng): Fix const-correctness issues and remove this overload.
- virtual const WebFrameImplBase* ToImplBase() const {
- return const_cast<WebFrame*>(this)->ToImplBase();
- }
-
// Returns the frame inside a given frame or iframe element. Returns 0 if
// the given element is not a frame, iframe or if the frame is empty.
BLINK_EXPORT static WebFrame* FromFrameOwnerElement(const WebElement&);
#if BLINK_IMPLEMENTATION
+ // TODO(mustaq): Should be named FromCoreFrame instead.
static WebFrame* FromFrame(Frame*);
+ BLINK_EXPORT static Frame* ToCoreFrame(const WebFrame&);
bool InShadowTree() const { return scope_ == WebTreeScopeType::kShadow; }
+ static void InitializeCoreFrame(WebFrame&, Page&);
static void TraceFrames(Visitor*, WebFrame*);
#endif
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/web/WebView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698