Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/public/web/WebFrame.h

Issue 2837593002: Nuked WebFrameImplBase. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebFrame.h
diff --git a/third_party/WebKit/public/web/WebFrame.h b/third_party/WebKit/public/web/WebFrame.h
index 9dfb4fb51943f0750822efedb65ecf46311b0163..013862c3f31698d3760271ad10dbdd39cbcb409e 100644
--- a/third_party/WebKit/public/web/WebFrame.h
+++ b/third_party/WebKit/public/web/WebFrame.h
@@ -50,6 +50,7 @@ class Local;
namespace blink {
+class Page;
class Frame;
class OpenedFrameTracker;
class Visitor;
@@ -60,7 +61,6 @@ class WebData;
class WebDataSource;
class WebDocument;
class WebElement;
-class WebFrameImplBase;
class WebLocalFrame;
class WebPerformance;
class WebRemoteFrame;
@@ -108,6 +108,11 @@ class WebFrame {
virtual bool IsWebRemoteFrame() const = 0;
virtual WebRemoteFrame* ToWebRemoteFrame() = 0;
+ virtual void InitializeCoreFrame(Page&) = 0;
+ // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be
+ // const...
+ virtual Frame* GetFrame() const = 0;
mustaq 2017/04/21 17:28:53 I think it makes sense to resolve this TODO in thi
+
BLINK_EXPORT bool Swap(WebFrame*);
// This method closes and deletes the WebFrame. This is typically called by
@@ -417,12 +422,6 @@ class WebFrame {
// text form. This is used only by layout tests.
virtual WebString LayerTreeAsText(bool show_debug_info = false) const = 0;
- virtual WebFrameImplBase* ToImplBase() = 0;
- // TODO(dcheng): Fix const-correctness issues and remove this overload.
- virtual const WebFrameImplBase* ToImplBase() const {
- return const_cast<WebFrame*>(this)->ToImplBase();
- }
-
// Returns the frame inside a given frame or iframe element. Returns 0 if
// the given element is not a frame, iframe or if the frame is empty.
BLINK_EXPORT static WebFrame* FromFrameOwnerElement(const WebElement&);
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698