Nuked WebFrameImplBase.

third_party/WebKit/public/web/WebFrame.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 34 matching lines @@
 class Function;
 class Value;
 template <class T>
 class Local;
 }
 
 namespace blink {
 
 class Frame;
 class OpenedFrameTracker;
+class Page;
 class Visitor;
 class WebAssociatedURLLoader;
 struct WebAssociatedURLLoaderOptions;
 class WebDOMEvent;
 class WebData;
 class WebDataSource;
 class WebDocument;
 class WebElement;
-class WebFrameImplBase;
 class WebLocalFrame;
 class WebPerformance;
 class WebRemoteFrame;
 class WebSecurityOrigin;
 class WebSharedWorkerRepositoryClient;
 class WebString;
 class WebURL;
 class WebURLRequest;
 class WebView;
 enum class WebSandboxFlags;
@@ skipping 336 matching lines @@
   // Returns the bounds rect for current selection. If selection is performed
   // on transformed text, the rect will still bound the selection but will
   // not be transformed itself. If no selection is present, the rect will be
   // empty ((0,0), (0,0)).
   virtual WebRect SelectionBoundsRect() const = 0;
 
   // Dumps the layer tree, used by the accelerated compositor, in
   // text form. This is used only by layout tests.
   virtual WebString LayerTreeAsText(bool show_debug_info = false) const = 0;
 
-  virtual WebFrameImplBase* ToImplBase() = 0;
-  // TODO(dcheng): Fix const-correctness issues and remove this overload.
-  virtual const WebFrameImplBase* ToImplBase() const {
-    return const_cast<WebFrame*>(this)->ToImplBase();
-  }
-
   // Returns the frame inside a given frame or iframe element. Returns 0 if
   // the given element is not a frame, iframe or if the frame is empty.
   BLINK_EXPORT static WebFrame* FromFrameOwnerElement(const WebElement&);
 
 #if BLINK_IMPLEMENTATION
   static WebFrame* FromFrame(Frame*);
 
+  static void InitializeCoreFrame(WebFrame*, Page&);

[dcheng, 2017/04/26 11:45:36]

Nit: WebFrame&, as the frame parameter should never be omitted.

Nit 2: group with TraceFrames() below, as it's conceptually somewhat similar.

[mustaq, 2017/04/26 18:12:48]

Done #2.

#1: Ref params must be const ref according to the style guide, but a const is
not allowed here because it calls Web*FrameImpl::InitializeCoreFrame() which is
not a const function.

[dcheng, 2017/04/27 02:22:36]

Mutable references are fine in Blink though: this is one of the style exceptions
that we carved out in Blink (hence Page& instead of Page*)

(And I think we should make ToCoreFrame take a ref as well, since all the
original callers must have passed a non-null WebFrame)

[mustaq, 2017/04/27 14:21:21]

Done.

+  static Frame* CoreFrame(const WebFrame*);

[dcheng, 2017/04/26 11:45:37]

Nit: ToCoreFrame

[mustaq, 2017/04/26 18:12:48]

Done.

But it seems |FromFrame| should now be called |FromCoreFrame| :(
Wdyt?

[dcheng, 2017/04/27 02:22:36]

Sure, we can do that in a separate change though.

[mustaq, 2017/04/27 14:21:21]

Added a TODO.

+
   bool InShadowTree() const { return scope_ == WebTreeScopeType::kShadow; }
 
   static void TraceFrames(Visitor*, WebFrame*);
 #endif
 
  protected:
   explicit WebFrame(WebTreeScopeType);
   virtual ~WebFrame();
 
   // Sets the parent WITHOUT fulling adding it to the frame tree.
@@ skipping 18 matching lines @@
   WebFrame* first_child_;
   WebFrame* last_child_;
 
   WebFrame* opener_;
   std::unique_ptr<OpenedFrameTracker> opened_frame_tracker_;
 };
 
 }  // namespace blink
 
 #endif