Nuked WebFrameImplBase.

third_party/WebKit/Source/web/WebRemoteFrameImpl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebRemoteFrameImpl_h
 #define WebRemoteFrameImpl_h
 
 #include "core/frame/RemoteFrame.h"
 #include "platform/heap/SelfKeepAlive.h"
 #include "platform/wtf/Compiler.h"
 #include "public/platform/WebInsecureRequestPolicy.h"
 #include "public/web/WebRemoteFrame.h"
 #include "public/web/WebRemoteFrameClient.h"
 #include "web/RemoteFrameClientImpl.h"
 #include "web/WebExport.h"
-#include "web/WebFrameImplBase.h"
 
 namespace blink {
 
 class FrameOwner;
 class RemoteFrame;
 enum class WebFrameLoadType;
 class WebAssociatedURLLoader;
 struct WebAssociatedURLLoaderOptions;
 
 class WEB_EXPORT WebRemoteFrameImpl final
-    : public WebFrameImplBase,
+    : public GarbageCollectedFinalized<WebRemoteFrameImpl>,
       NON_EXPORTED_BASE(public WebRemoteFrame) {
  public:
   static WebRemoteFrameImpl* Create(WebTreeScopeType,
                                     WebRemoteFrameClient*,
                                     WebFrame* opener = nullptr);
   ~WebRemoteFrameImpl() override;
 
   // WebFrame methods:
   void Close() override;
   WebString AssignedName() const override;
@@ skipping 60 matching lines @@
   bool IsPrintScalingDisabledForPlugin(const WebNode&) override;
   void PrintPagesWithBoundaries(WebCanvas*, const WebSize&) override;
   void DispatchMessageEventWithOriginCheck(
       const WebSecurityOrigin& intended_target_origin,
       const WebDOMEvent&) override;
 
   WebRect SelectionBoundsRect() const override;
 
   WebString LayerTreeAsText(bool show_debug_info = false) const override;
 
-  WebFrameImplBase* ToImplBase() { return this; }
-
-  // WebFrameImplBase methods:
-  void InitializeCoreFrame(Page&,
-                           FrameOwner*,
-                           const AtomicString& name) override;
-  RemoteFrame* GetFrame() const override { return frame_.Get(); }
+  // TODO(mustaq): regroup these to WebFrame or WebRemoteFrame

[dcheng, 2017/04/26 11:45:34]

I don't understand this TODO. What's your followup plan?

[mustaq, 2017/04/26 18:12:48]

These were TODO for this CL. Done: moved them to non-overridden methods below.
Same in *Local*.h .

+  void InitializeCoreFrame(Page&, FrameOwner*, const AtomicString& name);
+  RemoteFrame* GetFrame() const { return frame_.Get(); }
 
   void SetCoreFrame(RemoteFrame*);
 
   WebRemoteFrameClient* Client() const { return client_; }
 
   static WebRemoteFrameImpl* FromFrame(RemoteFrame&);
 
   // WebRemoteFrame methods:
   WebLocalFrame* CreateLocalChild(WebTreeScopeType,
                                   const WebString& name,
@@ skipping 56 matching lines @@
 
 DEFINE_TYPE_CASTS(WebRemoteFrameImpl,
                   WebFrame,
                   frame,
                   frame->IsWebRemoteFrame(),
                   frame.IsWebRemoteFrame());
 
 }  // namespace blink
 
 #endif  // WebRemoteFrameImpl_h