Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: third_party/WebKit/public/web/WebView.h

Issue 2837593002: Nuked WebFrameImplBase. (Closed)
Patch Set: Replaced non-null params with refs. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebFrame.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // Creates a WebView that is NOT yet initialized. You will need to 121 // Creates a WebView that is NOT yet initialized. You will need to
122 // call setMainFrame to finish the initialization. It is valid 122 // call setMainFrame to finish the initialization. It is valid
123 // to pass a null client pointer. The WebPageVisibilityState defines the 123 // to pass a null client pointer. The WebPageVisibilityState defines the
124 // initial visibility of the page. 124 // initial visibility of the page.
125 BLINK_EXPORT static WebView* Create(WebViewClient*, WebPageVisibilityState); 125 BLINK_EXPORT static WebView* Create(WebViewClient*, WebPageVisibilityState);
126 126
127 // After creating a WebView, you should immediately call this method. 127 // After creating a WebView, you should immediately call this method.
128 // You can optionally modify the settings before calling this method. 128 // You can optionally modify the settings before calling this method.
129 // This WebFrame will receive events for the main frame and must not 129 // This WebFrame will receive events for the main frame and must not
130 // be null. 130 // be null.
131 // TODO(mustaq): The non-null param should be a reference.
131 virtual void SetMainFrame(WebFrame*) = 0; 132 virtual void SetMainFrame(WebFrame*) = 0;
132 133
133 // Initializes the various client interfaces. 134 // Initializes the various client interfaces.
134 virtual void SetCredentialManagerClient(WebCredentialManagerClient*) = 0; 135 virtual void SetCredentialManagerClient(WebCredentialManagerClient*) = 0;
135 virtual void SetPrerendererClient(WebPrerendererClient*) = 0; 136 virtual void SetPrerendererClient(WebPrerendererClient*) = 0;
136 virtual void SetSpellCheckClient(WebSpellCheckClient*) = 0; 137 virtual void SetSpellCheckClient(WebSpellCheckClient*) = 0;
137 138
138 // Options ------------------------------------------------------------- 139 // Options -------------------------------------------------------------
139 140
140 // The returned pointer is valid for the lifetime of the WebView. 141 // The returned pointer is valid for the lifetime of the WebView.
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 // completed. 496 // completed.
496 WebWidget* GetWidget() { return this; } 497 WebWidget* GetWidget() { return this; }
497 498
498 protected: 499 protected:
499 ~WebView() {} 500 ~WebView() {}
500 }; 501 };
501 502
502 } // namespace blink 503 } // namespace blink
503 504
504 #endif 505 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/public/web/WebFrame.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698