Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2837583003: Actually disable WebVrTest#testScreenTapsRegisteredOnCardboard (Closed)

Created:
3 years, 8 months ago by bsheedy
Modified:
3 years, 8 months ago
Reviewers:
nyquist, mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Actually disable WebVrTest#testScreenTapsRegisteredOnCardboard https://codereview.chromium.org/2832883002 was supposed to disable the test due to flakiness, but the wrong test got disabled. BUG=713781

Patch Set 1 #

Patch Set 2 : Re-add LargeTest import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837583003/1
3 years, 8 months ago (2017-04-21 18:43:23 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-21 18:43:24 UTC) #5
bsheedy
PTAL
3 years, 8 months ago (2017-04-21 18:44:45 UTC) #8
mthiesse
lgtm
3 years, 8 months ago (2017-04-21 18:44:53 UTC) #10
bsheedy
3 years, 8 months ago (2017-04-21 21:21:54 UTC) #11
Message was sent while issue was closed.
Handled in https://codereview.chromium.org/2837473004/

Powered by Google App Engine
This is Rietveld 408576698