Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2837473002: merge fasta.PrecedenceInfo into analyzer.TokenType (Closed)

Created:
3 years, 8 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

merge fasta.PrecedenceInfo into analyzer.TokenType * move precedence consts into analyzer token.dart * move PrecedenceInfo.all to TokenType.all * replace references to PrecedenceInfo with TokenType * merge fasta.PrecedenceInfo into analyzer.TokenType R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/54d131ebd9502fbb195f6214cf101fbbc715e93b

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -303 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/fasta/token_utils.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 3 chunks +10 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 8 chunks +14 lines, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 10 chunks +10 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/error_token.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/precedence.dart View 1 chunk +120 lines, -208 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/recover.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/string_scanner.dart View 4 chunks +5 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 13 chunks +19 lines, -25 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart View 2 chunks +5 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 5 chunks +100 lines, -3 lines 0 comments Download
M pkg/front_end/test/precedence_info_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
danrubel
3 years, 8 months ago (2017-04-21 00:14:07 UTC) #2
Paul Berry
lgtm
3 years, 8 months ago (2017-04-21 07:05:28 UTC) #3
scheglov
lgtm https://codereview.chromium.org/2837473002/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart File pkg/compiler/lib/src/resolution/enum_creator.dart (right): https://codereview.chromium.org/2837473002/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart#newcode53 pkg/compiler/lib/src/resolution/enum_creator.dart:53: Token symbolToken(TokenType info) { Should these parameters and ...
3 years, 8 months ago (2017-04-21 18:08:38 UTC) #5
danrubel
https://codereview.chromium.org/2837473002/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart File pkg/compiler/lib/src/resolution/enum_creator.dart (right): https://codereview.chromium.org/2837473002/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart#newcode53 pkg/compiler/lib/src/resolution/enum_creator.dart:53: Token symbolToken(TokenType info) { On 2017/04/21 18:08:38, scheglov wrote: ...
3 years, 8 months ago (2017-04-21 18:48:51 UTC) #6
danrubel
Committed patchset #2 (id:20001) manually as 54d131ebd9502fbb195f6214cf101fbbc715e93b (presubmit successful).
3 years, 8 months ago (2017-04-23 13:13:32 UTC) #8
danrubel
On 2017/04/21 18:48:51, danrubel wrote: > https://codereview.chromium.org/2837473002/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart > File pkg/compiler/lib/src/resolution/enum_creator.dart (right): > > https://codereview.chromium.org/2837473002/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart#newcode53 > ...
3 years, 7 months ago (2017-05-08 15:33:06 UTC) #9
ahe
3 years, 6 months ago (2017-05-31 13:30:33 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698