Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: components/storage_monitor/volume_mount_watcher_win.cc

Issue 2837453002: Remove more unmapped media galleries histograms. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/storage_monitor/storage_monitor_linux.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/storage_monitor/volume_mount_watcher_win.cc
diff --git a/components/storage_monitor/volume_mount_watcher_win.cc b/components/storage_monitor/volume_mount_watcher_win.cc
index 5ac0b11139560f4b25b5c55a6f60e094bf24e955..17e7a63034c2573991d534377004c127e7f8a585 100644
--- a/components/storage_monitor/volume_mount_watcher_win.cc
+++ b/components/storage_monitor/volume_mount_watcher_win.cc
@@ -16,7 +16,6 @@
#include <algorithm>
#include "base/bind_helpers.h"
-#include "base/metrics/histogram_macros.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
@@ -47,15 +46,6 @@ enum DeviceType {
FIXED,
};
-// Histogram values for recording frequencies of eject attempts and
-// outcomes.
-enum EjectWinLockOutcomes {
- LOCK_ATTEMPT,
- LOCK_TIMEOUT,
- LOCK_TIMEOUT2,
- NUM_LOCK_OUTCOMES,
-};
-
// We are trying to figure out whether the drive is a fixed volume,
// a removable storage, or a floppy. A "floppy" here means "a volume we
// want to basically ignore because it won't fit media and will spin
@@ -262,12 +252,7 @@ void EjectDeviceInThreadPool(
// handle is closed, and this is done by the ScopedHandle above.
BOOL locked = DeviceIoControl(volume_handle.Get(), FSCTL_LOCK_VOLUME,
NULL, 0, NULL, 0, &bytes_returned, NULL);
- UMA_HISTOGRAM_ENUMERATION("StorageMonitor.EjectWinLock",
- LOCK_ATTEMPT, NUM_LOCK_OUTCOMES);
if (!locked) {
- UMA_HISTOGRAM_ENUMERATION("StorageMonitor.EjectWinLock",
- iteration == 0 ? LOCK_TIMEOUT : LOCK_TIMEOUT2,
- NUM_LOCK_OUTCOMES);
const int kNumLockRetries = 1;
const base::TimeDelta kLockRetryInterval =
base::TimeDelta::FromMilliseconds(500);
« no previous file with comments | « components/storage_monitor/storage_monitor_linux.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698