Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: chrome/browser/media/router/media_router_feature.cc

Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl (Closed)
Patch Set: resolve code review comments from Kevin Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router_feature.cc
diff --git a/chrome/browser/media/router/media_router_feature.cc b/chrome/browser/media/router/media_router_feature.cc
index 5e636a39f4a110898c3df1b6e3ad9053c86fbb47..690a3c34af3951b7d45c5c3759667f39f4c842c3 100644
--- a/chrome/browser/media/router/media_router_feature.cc
+++ b/chrome/browser/media/router/media_router_feature.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/media/router/media_router_feature.h"
+#include "base/feature_list.h"
#include "build/build_config.h"
#include "content/public/browser/browser_context.h"
#include "extensions/features/features.h"
@@ -16,6 +17,16 @@
namespace media_router {
+#if !defined(OS_ANDROID)
+// Controls if browser side DIAL device discovery is enabled.
+const base::Feature kEnableDialLocalDiscovery{
Kevin M 2017/05/08 18:22:19 Class-typed variables (like Feature) cannot have s
zhaobin 2017/05/08 20:13:48 chrome_features.cc uses it this way... https://cs.
+ "EnableDialLocalDiscovery", base::FEATURE_DISABLED_BY_DEFAULT};
+
+// Controls if browser side Cast device discovery is enabled.
+const base::Feature kEnableCastDiscovery{"EnableCastDiscovery",
+ base::FEATURE_DISABLED_BY_DEFAULT};
+#endif
+
#if defined(OS_ANDROID) || BUILDFLAG(ENABLE_EXTENSIONS)
namespace {
const PrefService::Preference* GetMediaRouterPref(
@@ -41,4 +52,16 @@ bool MediaRouterEnabled(content::BrowserContext* context) {
#endif // defined(OS_ANDROID) || BUILDFLAG(ENABLE_EXTENSIONS)
}
+#if !defined(OS_ANDROID)
+// Returns true if browser side DIAL discovery is enabled.
+bool DialLocalDiscoveryEnabled() {
+ return base::FeatureList::IsEnabled(kEnableDialLocalDiscovery);
+}
+
+// Returns true if browser side Cast discovery is enabled.
+bool CastDiscoveryEnabled() {
+ return base::FeatureList::IsEnabled(kEnableCastDiscovery);
+}
+#endif
+
} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698