Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4785)

Unified Diff: chrome/common/media_router/mojo/media_router.mojom

Issue 2837363002: [Media Router] Use DialMediaSinkService in MediaRouterMojoImpl (Closed)
Patch Set: resolve code review comments from Mark Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/media_router/mojo/media_router.mojom
diff --git a/chrome/common/media_router/mojo/media_router.mojom b/chrome/common/media_router/mojo/media_router.mojom
index f1c657680314510c0ed740c22ce65c529ea58093..cf627934aedf56892d107d35b446bd677411c94b 100644
--- a/chrome/common/media_router/mojo/media_router.mojom
+++ b/chrome/common/media_router/mojo/media_router.mojom
@@ -187,6 +187,15 @@ enum RouteRequestResultCode {
// New values must be added here.
};
+// Pass feature flags from browser to Media Route Provider
Kevin M 2017/05/03 21:07:28 Used to pass feature configuration data from the B
zhaobin 2017/05/04 23:52:36 Done.
+struct MediaRouteProviderConfig {
+ // If the MRP should enable DIAL discovery in component extension.
Kevin M 2017/05/03 21:07:28 Nit: It seems like the component extension part is
zhaobin 2017/05/04 23:52:36 Done.
+ bool enable_dial_discovery;
+
+ // If the MRP should enable Cast discovery in component extension.
+ bool enable_cast_discovery;
+};
+
// Modeled after the MediaRouter interface defined in
// chrome/browser/media/router/media_router.h
interface MediaRouteProvider {
@@ -423,7 +432,7 @@ interface MediaRouter {
// Returns a string that uniquely identifies the Media Router browser
// process.
RegisterMediaRouteProvider(MediaRouteProvider media_router_provider) =>
- (string instance_id);
+ (string instance_id, MediaRouteProviderConfig config);
// Called when the Media Route Manager receives a new list of |sinks|
// compatible with |media_source|. The result is only valid for |origins|. If

Powered by Google App Engine
This is Rietveld 408576698